Skip to content

dnsmasq: 2.88 -> 2.89#220015

Merged
fpletz merged 1 commit intoNixOS:stagingfrom
r-ryantm:auto-update/dnsmasq
Mar 8, 2023
Merged

dnsmasq: 2.88 -> 2.89#220015
fpletz merged 1 commit intoNixOS:stagingfrom
r-ryantm:auto-update/dnsmasq

Conversation

@r-ryantm
Copy link
Contributor

@r-ryantm r-ryantm commented Mar 7, 2023

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/dnsmasq/versions.

meta.description for dnsmasq is: An integrated DNS, DHCP and TFTP server for small networks

meta.homepage for dnsmasq is: https://www.thekelleys.org.uk/dnsmasq/doc.html

Updates performed
  • Version update
To inspect upstream changes
Impact
Checks done (click to expand)
  • built on NixOS
  • The tests defined in passthru.tests, if any, passed
  • found 2.89 with grep in /nix/store/yr4c0qrb4z2mjcikd2wg53vyz0is3837-dnsmasq-2.89
  • found 2.89 in filename of file in /nix/store/yr4c0qrb4z2mjcikd2wg53vyz0is3837-dnsmasq-2.89
Rebuild report (if merged into master) (click to expand) 
701 total rebuild path(s)

701 package rebuild(s)

First fifty rebuilds by attrpath
ChowKick
CuboCore.coretoppings
adapta-gtk-theme
adwaita-qt6
airgeddon
alfis
alice-tools-qt6
almanah
apache-directory-studio
apostrophe
appgate-sdp
appvm
astroid
autosuspend
aws-workspaces
balsa
bambootracker-qt6
beamerpresenter
beamerpresenter-mupdf
beamerpresenter-poppler
bespokesynth
bespokesynth-with-vst2
birdfont
blueman
bookworm
breath-theme
bubblemail
calcmysky
calibre
calligra
calls
cambalache
cargo-tauri
cawbird
chatty
chirp
cinnamon.cinnamon-common
cinnamon.cinnamon-control-center
cinnamon.cinnamon-gsettings-overrides
cinnamon.cinnamon-screensaver
cinnamon.cinnamon-session
cinnamon.cinnamon-settings-daemon
cinnamon.nemo-fileroller
cinnamon.nemo-with-extensions
cinnamon.pix
cinnamon.xreader
cinny-desktop
citrix_workspace
citrix_workspace_23_02_0
clash-verge
Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/yr4c0qrb4z2mjcikd2wg53vyz0is3837-dnsmasq-2.89 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A dnsmasq https://github.com/r-ryantm/nixpkgs/archive/0070f29a1327858c5ca976f341496b86597e5c2d.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/yr4c0qrb4z2mjcikd2wg53vyz0is3837-dnsmasq-2.89
ls -la /nix/store/yr4c0qrb4z2mjcikd2wg53vyz0is3837-dnsmasq-2.89/bin

Pre-merge build results

NixPkgs review skipped

Maintainer pings

cc @edolstra @fpletz @globin for testing.

@ofborg ofborg bot requested review from edolstra, fpletz and globin March 7, 2023 17:27
@ofborg ofborg bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 501-1000 This PR causes many rebuilds on Linux and should normally target the staging branches. labels Mar 7, 2023
fpletz
fpletz approved these changes Mar 8, 2023
View reviewed changes
Copy link
Member

@fpletz fpletz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bugfix release: https://thekelleys.org.uk/dnsmasq/CHANGELOG

version 2.89
Fix bug introduced in 2.88 (commit fe91134b) which can result
in corruption of the DNS cache internal data structures and
logging of "cache internal error". This has only been seen
in one place in the wild, and it took considerable effort
to even generate a test case to reproduce it, but there's
no way to be sure it won't strike, and the effect is to break
the cache badly. Installations with DNSSEC enabled are more
likely to see the problem, but not running DNSSEC does not
guarantee that it won't happen. Thanks to Timo van Roermund
for reporting the bug and for his great efforts in chasing
it down.

@fpletz fpletz merged commit fe54abb into NixOS:staging Mar 8, 2023
@r-ryantm r-ryantm deleted the auto-update/dnsmasq branch March 8, 2023 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fpletz fpletz fpletz approved these changes

@globin globin Awaiting requested review from globin

@edolstra edolstra Awaiting requested review from edolstra

Assignees

No one assigned

Labels

10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 501-1000 This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@r-ryantm @fpletz