Skip to content

sphinx-rtd-theme: fix missing docutils for cross compilation#219835

Merged
marsam merged 1 commit intoNixOS:stagingfrom
Cynerd:sphinx-rtd-theme-cross
Mar 8, 2023
Merged

sphinx-rtd-theme: fix missing docutils for cross compilation#219835
marsam merged 1 commit intoNixOS:stagingfrom
Cynerd:sphinx-rtd-theme-cross

Conversation

@Cynerd
Copy link
Contributor

@Cynerd Cynerd commented Mar 6, 2023

The tests are disabled when cross compiling. The effect of adding pythonRelaxDepsHook to check inputs is that it is skipped when cross compiling or when checks are disabled.

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: cross-compilation Building packages on a different platform than they will be used on label Mar 6, 2023
@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Mar 6, 2023
@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 2501-5000 This PR causes many rebuilds on Darwin and should target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Mar 6, 2023
Copy link
Contributor

@marsam marsam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please target staging

@marsam marsam changed the base branch from master to staging-next March 8, 2023 06:35
@marsam marsam changed the base branch from staging-next to staging March 8, 2023 06:37
@ofborg ofborg bot added 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches. and removed 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Mar 8, 2023
The tests are disabled when cross compiling. The effect of adding
pythonRelaxDepsHook to check inputs is that it is skipped when cross
compiling or when checks are disabled.
@Cynerd Cynerd force-pushed the sphinx-rtd-theme-cross branch from 87fe926 to 2d29fbd Compare March 8, 2023 07:48
@Cynerd
Copy link
Contributor Author

Cynerd commented Mar 8, 2023

LGTM. Please target staging

Done.

@marsam marsam merged commit 3560f92 into NixOS:staging Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: cross-compilation Building packages on a different platform than they will be used on 6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 2501-5000 This PR causes many rebuilds on Darwin and should target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants