sphinx-rtd-theme: fix missing docutils for cross compilation#219835
Merged
marsam merged 1 commit intoNixOS:stagingfrom Mar 8, 2023
Merged
sphinx-rtd-theme: fix missing docutils for cross compilation#219835marsam merged 1 commit intoNixOS:stagingfrom
marsam merged 1 commit intoNixOS:stagingfrom
Conversation
marsam
approved these changes
Mar 8, 2023
Contributor
marsam
left a comment
There was a problem hiding this comment.
LGTM. Please target staging
The tests are disabled when cross compiling. The effect of adding pythonRelaxDepsHook to check inputs is that it is skipped when cross compiling or when checks are disabled.
87fe926 to
2d29fbd
Compare
Contributor
Author
Done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tests are disabled when cross compiling. The effect of adding pythonRelaxDepsHook to check inputs is that it is skipped when cross compiling or when checks are disabled.
Description of changes
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)