Skip to content

Fixup editorconfig action with Nix 2.14.0#218858

Merged
wegank merged 1 commit intoNixOS:masterfrom
cole-h:fixup-editorconfig-action
Feb 28, 2023
Merged

Fixup editorconfig action with Nix 2.14.0#218858
wegank merged 1 commit intoNixOS:masterfrom
cole-h:fixup-editorconfig-action

Conversation

@cole-h
Copy link
Member

@cole-h cole-h commented Feb 28, 2023 •
edited
Loading

Description of changes

Supercedes #218853 (if this actually works lol).

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: policy discussion Discuss policies to work in and around Nixpkgs label Feb 28, 2023
@cole-h cole-h force-pushed the fixup-editorconfig-action branch from e14dc64 to 6f22d9c Compare February 28, 2023 19:35
@cole-h cole-h force-pushed the fixup-editorconfig-action branch from 6f22d9c to 19a122e Compare February 28, 2023 19:36
@cole-h cole-h marked this pull request as ready for review February 28, 2023 19:37
@cole-h cole-h requested review from a team, Mic92 and zowoq as code owners February 28, 2023 19:37
@cole-h
Copy link
Member Author

cole-h commented Feb 28, 2023

Successful run due to switching to nix-shell: https://github.com/NixOS/nixpkgs/actions/runs/4296726730/jobs/7488798463

@cole-h cole-h mentioned this pull request Feb 28, 2023
Closed
12 tasks
@cole-h
Copy link
Member Author

cole-h commented Feb 28, 2023

For posterity: the issue is that, with Nix 2.14.0, some shenanigans happened with the install script and ~/.nix-profile/bin disappeared from $PATH. We can "get around this" by using nix-shell (which is arguably the proper solution regardless of this issue, as @figsoda pointed out in the dev room on Matrix), and we can continue chasing the bug down upstream in Nix.

Possible candidates that caused this are:

NixOS/nix#5588 (most likely, IMVHO, but no evidence yet)
NixOS/nix#5226

@cole-h cole-h mentioned this pull request Feb 28, 2023
Merged
8 tasks
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Feb 28, 2023
@wegank wegank merged commit 31ce09b into NixOS:master Feb 28, 2023
@cole-h cole-h deleted the fixup-editorconfig-action branch February 28, 2023 20:34
@Gerschtli Gerschtli mentioned this pull request Feb 28, 2023
Closed
ncfavier added a commit to ncfavier/home-manager that referenced this pull request Feb 28, 2023
@ncfavier
.github: pin nix 2.13 in workflows
b09a84c 
2.14 has a bug related to profile locations that breaks nix-env, which
in turn breaks cachix. Pin to 2.13 for now.

More info at NixOS/nixpkgs#218858 (comment)
@ncfavier ncfavier mentioned this pull request Feb 28, 2023
Merged
ncfavier added a commit to NixOS/nixos-search that referenced this pull request Feb 28, 2023
@ncfavier
.github: pin nix 2.13
6e53d34 
2.14 has a bug related to profile locations that breaks nix-env, which
in turn breaks cachix. Pin to 2.13 for now.

More info at NixOS/nixpkgs#218858 (comment)
@ncfavier ncfavier mentioned this pull request Feb 28, 2023
Merged
ncfavier added a commit to NixOS/nixos-search that referenced this pull request Feb 28, 2023
@ncfavier
.github: pin nix 2.13 (#630)
218c6dc 
2.14 has a bug related to profile locations that breaks nix-env, which
in turn breaks cachix. Pin to 2.13 for now.

More info at NixOS/nixpkgs#218858 (comment)
@pennae pennae mentioned this pull request Feb 28, 2023
Merged
12 tasks
ncfavier added a commit to nix-community/home-manager that referenced this pull request Feb 28, 2023
@ncfavier
.github: pin nix 2.13 in workflows (#3720)
9438e56 
2.14 has a bug related to profile locations that breaks nix-env, which
in turn breaks cachix. Pin to 2.13 for now.

More info at NixOS/nixpkgs#218858 (comment)
zowoq pushed a commit that referenced this pull request Feb 28, 2023
@pennae @zowoq
workflows: pin install-nix-action to use nix 2.13.3
3563c17 
same reasoning as #218858, only now for an action we depend on and can't
fix quite as easily. cachix-action also uses nix-env and will thus not
work correctly, so pin the nix version used to the last known good one.
@seppeljordan seppeljordan mentioned this pull request Feb 28, 2023
Merged
@ehildenb ehildenb mentioned this pull request Feb 28, 2023
Merged
@zowoq zowoq mentioned this pull request Feb 28, 2023
Merged
12 tasks
tricktron added a commit to tricktron/openapi2jsonschema that referenced this pull request Mar 1, 2023
@tricktron
fix: pin to nix 2.13.3 version
321d6cd 
In Nix 2.14.0 the `~/.nix-profile/bin` path is not on the `$PATH` anymore.
As a result, cachix cannot find the binary after installation.

Downgrading to 2.13.3 solves the issue.

See NixOS/nixpkgs#218858 (comment)
for more information.
@tricktron tricktron mentioned this pull request Mar 1, 2023
Merged
@tobim tobim mentioned this pull request Mar 1, 2023
Merged
Dakostu pushed a commit to tenzir/tenzir that referenced this pull request Mar 1, 2023
Pin Nix version to temporarily circumvent Nix CI failures
0b90d48 
See: NixOS/nixpkgs#218858 (comment)
@Dakostu Dakostu mentioned this pull request Mar 1, 2023
Closed
@thufschmitt
Copy link
Member

thufschmitt commented Mar 1, 2023

Investigated this a bit. The issue is indeed due to NixOS/nix#5226 . There was supposed to be some backwards-compat logic to make the old paths still work, but it's evidently broken, as well as the corresponding tests.

There's already a fix on cachix's side (https://github.com/cachix/install-nix-action/releases/tag/v20, thanks @domenkozar for the incredible reactivity :) ) and I'll try to submit one for Nix itself today

@thufschmitt thufschmitt mentioned this pull request Mar 1, 2023
Closed
kalbasit pushed a commit to kalbasit/home-manager that referenced this pull request Mar 1, 2023
@ncfavier @kalbasit
.github: pin nix 2.13 in workflows (nix-community#3720)
cb5c01c 
2.14 has a bug related to profile locations that breaks nix-env, which
in turn breaks cachix. Pin to 2.13 for now.

More info at NixOS/nixpkgs#218858 (comment)

(cherry picked from commit 9438e56)
ereslibre added a commit to ereslibre/homelab that referenced this pull request Mar 2, 2023
@ereslibre
Update: pin nix to 2.13.3
c9db289 
Due to
NixOS/nixpkgs#218858 (comment)
and nix-community/home-manager#2544
ereslibre added a commit to ereslibre/homelab-old that referenced this pull request Mar 2, 2023
@ereslibre
Update: pin nix to 2.13.3
0a9c98a 
Due to
NixOS/nixpkgs#218858 (comment)
and nix-community/home-manager#2544
15cm pushed a commit to 15cm/home-manager that referenced this pull request Apr 22, 2023
@ncfavier @15cm
.github: pin nix 2.13 in workflows (nix-community#3720)
7f7a6db 
2.14 has a bug related to profile locations that breaks nix-env, which
in turn breaks cachix. Pin to 2.13 for now.

More info at NixOS/nixpkgs#218858 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mic92 Mic92 Awaiting requested review from Mic92

@zowoq zowoq Awaiting requested review from zowoq

1 more reviewer

@figsoda figsoda figsoda approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: policy discussion Discuss policies to work in and around Nixpkgs 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cole-h @thufschmitt @figsoda @wegank