Skip to content

gnupg: look for system wide config files at /etc/gnupg/* rather than …#218703

Merged
Artturin merged 1 commit intoNixOS:stagingfrom
SuperSandro2000:gnupg-sysconfdir
Apr 12, 2023
Merged

gnupg: look for system wide config files at /etc/gnupg/* rather than …#218703
Artturin merged 1 commit intoNixOS:stagingfrom
SuperSandro2000:gnupg-sysconfdir

Conversation

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Feb 27, 2023

…in the nix store

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from fpletz and vrthra February 27, 2023 23:30
@ofborg ofborg bot added 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Feb 27, 2023
@SuperSandro2000 SuperSandro2000 requested review from rnhmjoj and removed request for fpletz and vrthra February 27, 2023 23:34
@SuperSandro2000 SuperSandro2000 changed the base branch from master to staging February 27, 2023 23:35
@rnhmjoj
Copy link
Contributor

rnhmjoj commented Feb 28, 2023

What kind of configuration is this path supposed to contain? The package doesn't ship with any.

@SuperSandro2000
Copy link
Member Author

SuperSandro2000 commented Apr 11, 2023

Global gpg configs, similar to ~/.gnupg. Before this, gnupg would look into the nix store where the config will be never.

@ofborg ofborg bot requested review from fpletz and vrthra April 11, 2023 11:55
@rnhmjoj
Copy link
Contributor

rnhmjoj commented Apr 11, 2023

Would this help with #213794?

@SuperSandro2000
Copy link
Member Author

SuperSandro2000 commented Apr 11, 2023

We could write the config into the global directory which I hope helps but I didn't try it in practice.

@Artturin Artturin merged commit 956d034 into NixOS:staging Apr 12, 2023
@SuperSandro2000 SuperSandro2000 deleted the gnupg-sysconfdir branch April 18, 2023 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rnhmjoj rnhmjoj rnhmjoj approved these changes

@vrthra vrthra Awaiting requested review from vrthra

@fpletz fpletz Awaiting requested review from fpletz

Assignees

No one assigned

Labels

10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@SuperSandro2000 @rnhmjoj @Artturin