Skip to content

i3blocks: specify supported platforms#21858

Merged
7c6f434c merged 1 commit intomasterfrom
unknown repository
Jan 13, 2017
Merged

i3blocks: specify supported platforms#21858
7c6f434c merged 1 commit intomasterfrom
unknown repository

Conversation

@ghost
Copy link

@ghost ghost commented Jan 13, 2017

Motivation for this change

Not all platforms are support as discussed in #21839.

Don't have Nix atm., but figured I would send the PR, as this would at least hinder install on non--known-supported platforms.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@7c6f434c 7c6f434c merged commit f30a854 into NixOS:master Jan 13, 2017
@7c6f434c
Copy link
Member

OpenBSD, NetBSD and IllumOS Nix users — if any of them care about window managers in NixPkgs — are welcome to submit specific complaints

@Ericson2314
Copy link
Member

This broke master. I think it needs a with platforms;? Also, might there be a plain bsd platform list for bsd ++ linux?

@7c6f434c
Copy link
Member

7c6f434c commented Jan 13, 2017 via email

@Ericson2314
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants