Skip to content

Comments

p3x-onenote: set supported platforms#218203

Merged
wegank merged 1 commit intoNixOS:masterfrom
davidak:p3x-onenote-fix
Feb 25, 2023
Merged

p3x-onenote: set supported platforms#218203
wegank merged 1 commit intoNixOS:masterfrom
davidak:p3x-onenote-fix

Conversation

@davidak
Copy link
Member

@davidak davidak commented Feb 25, 2023

Description of changes

fixing build issue on not supported platforms

Fixes #217976

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

fixing build issue on not supported platforms
@davidak
Copy link
Member Author

davidak commented Feb 25, 2023

Result of nixpkgs-review pr 218203 run on x86_64-linux 1

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Feb 25, 2023
@wegank wegank merged commit 0c9de79 into NixOS:master Feb 25, 2023
@davidak davidak deleted the p3x-onenote-fix branch February 25, 2023 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

p3x-onenote error: attribute 'i686-linux' missing

2 participants