Merged
Conversation
7d0754e to
3fd598b
Compare
Contributor
|
rebased onto a base on which it actually builds (for some reason, even though ofborg succeeded, compilation failed locally). also applied the upstream patch for #226526, which seems to resolve the issue |
Member
|
It looks like ofborg failed on x86_64-linux because parallel builds are busted (but there is also a commit to fix it). Ref: ibus/ibus#2501 |
3fd598b to
1b8ed6c
Compare
Contributor
|
added that patch too. hopefully this fixes all issues |
see NixOS#226526, ibus/ibus#2496, NixOS#218120 (comment) codepoint and emoji input simply don't show due to runtime initialization issues, and a missing make dependency makes the build flaky.
1b8ed6c to
e988628
Compare
Contributor
|
hurrah, it finally built. 😒 the upstream patch fixing the makefile does seem to be incomplete at best. |
wegank
approved these changes
Apr 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/ibus/ibus/releases.
meta.description for ibus is: Intelligent Input Bus, input method framework
meta.homepage for ibus is: https://github.com/ibus/ibus
Updates performed
To inspect upstream changes
Release on GitHub
Compare changes on GitHub
Impact
Checks done (click to expand)
passthru.tests, if any, passedRebuild report (if merged into master) (click to expand)
Instructions to test this update (click to expand)
Either download from Cachix:
(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the
trusted-userslist or you can usesudosince root is effectively trusted.Or, build yourself:
After you've downloaded or built it, look at the files and if there are any, run the binaries:
Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of
nixpkgs-reviewrun on x86_64-linux 12 packages failed to build:
62 packages built:
Maintainer pings
cc @ttuegel @yanalunaterra for testing.