Skip to content

dav1d: 1.0.0 -> 1.1.0#218004

Merged
mweinelt merged 1 commit intoNixOS:stagingfrom
henrirosten:dav1d_update_to_1_1_0
Mar 4, 2023
Merged

dav1d: 1.0.0 -> 1.1.0#218004
mweinelt merged 1 commit intoNixOS:stagingfrom
henrirosten:dav1d_update_to_1_1_0

Conversation

@henrirosten
Copy link
Member

@henrirosten henrirosten commented Feb 24, 2023

Description of changes

Update dav1d to current latest version: https://github.com/videolan/dav1d/releases/tag/1.1.0. Also, start using the read-only mirror for dav1d source https://github.com/videolan/dav1d instead of the origin https://code.videolan.org/videolan/dav1d/. The reason is that the origin https://code.videolan.org/videolan/dav1d/ connection appears unstable.

This change was motivated by OSV item https://osv.dev/vulnerability/OSV-2022-674 identified by manual test run with vulnxscan.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@henrirosten henrirosten changed the base branch from master to staging February 24, 2023 11:16
@ofborg ofborg bot requested a review from primeos February 24, 2023 11:29
@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Feb 24, 2023
ajs124
ajs124 reviewed Feb 28, 2023
View reviewed changes
pkgs/development/libraries/dav1d/default.nix Outdated
Copy link
Member

@ajs124 ajs124 Feb 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
rev = "${version}";
rev = version;

why not leave it like that?

Copy link
Member Author

@henrirosten henrirosten Mar 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is now fixed in commit 4040da1.
I also changed the "sha256" to "hash", as you suggested in another PR here: #217986 (comment)

@henrirosten henrirosten force-pushed the dav1d_update_to_1_1_0 branch from 04e6a4e to 6ec5f88 Compare March 1, 2023 05:45
@github-actions github-actions bot added 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: pantheon The Pantheon desktop environment 6.topic: python Python is a high-level, general-purpose programming language. 6.topic: vscode A free and versatile code editor that supports almost every major programming language. 8.has: changelog This PR adds or changes release notes 8.has: documentation This PR adds or changes documentation labels Mar 1, 2023
@ofborg ofborg bot added 8.has: clean-up This PR removes packages or removes other cruft 8.has: package (new) This PR adds a new package labels Mar 1, 2023
@henrirosten
dav1d: 1.0.0 -> 1.1.0
4040da1 
Signed-off-by: Henri Rosten <[email protected]>
@henrirosten henrirosten force-pushed the dav1d_update_to_1_1_0 branch from 6ec5f88 to 4040da1 Compare March 1, 2023 06:06
@github-actions github-actions bot removed 6.topic: pantheon The Pantheon desktop environment 6.topic: python Python is a high-level, general-purpose programming language. 8.has: changelog This PR adds or changes release notes 6.topic: vscode A free and versatile code editor that supports almost every major programming language. 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: documentation This PR adds or changes documentation labels Mar 1, 2023
@henrirosten
Copy link
Member Author

henrirosten commented Mar 1, 2023 •
edited
Loading

Labels: "8.has: clean-up" and "8.has: package (new)" got added by ofborg after my incorrect rebase against master that was fixed in 4040da1.
Those two labels should be removed, but I'm unable to manually change them.

@henrirosten henrirosten requested review from ajs124 and removed request for jonringer, jtojnar, primeos and zowoq March 1, 2023 07:50
@ajs124 ajs124 removed 8.has: package (new) This PR adds a new package 8.has: clean-up This PR removes packages or removes other cruft labels Mar 1, 2023
@ajs124 ajs124 requested a review from primeos March 1, 2023 12:15
@mweinelt mweinelt merged commit d59f02e into NixOS:staging Mar 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ajs124 ajs124 ajs124 approved these changes

@primeos primeos Awaiting requested review from primeos

Assignees

No one assigned

Labels

10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@henrirosten @ajs124 @mweinelt