xdg-utils: patch xdg-open to correctly open files when using portal#217590
Merged
mweinelt merged 1 commit intoNixOS:stagingfrom Mar 4, 2023
Merged
Conversation
Member
|
Thanks for fixing this! Reviewed upstream PR, it has a bug. |
lilyinstarlight
force-pushed
the
fix/xdg-open-files-with-portal
branch
from
ba59feb to
bc6ff4b
Compare
Member
Author
Should be fixed now, thank you! |
See upstream MR at https://gitlab.freedesktop.org/xdg/xdg-utils/-/merge_requests/65 which adds support for the org.freedesktop.portal.OpenURI.OpenFile method.
lilyinstarlight
force-pushed
the
fix/xdg-open-files-with-portal
branch
from
bc6ff4b to
b1849a1
Compare
ofborg
bot
added
10.rebuild-darwin: 101-500
LunNova
added a commit
to LunNova/nixos-configs
that referenced
this pull request
Feb 22, 2023
LunNova
approved these changes
Feb 22, 2023
Member
LunNova
left a comment
LunNova
left a comment
There was a problem hiding this comment.
Added to system config last night and not noticing any new issues. Tested that opening files works now.
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
SuperSandro2000
approved these changes
Feb 26, 2023
huantianad
approved these changes
Mar 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Right now when
xdgOpenUsePortal = true, usingxdg-openfor filenames stops working becausexdg-openonly uses the URI method for the portal. This fixes that problem by pulling in an upstream MR with the needed functionalitySee upstream MR at https://gitlab.freedesktop.org/xdg/xdg-utils/-/merge_requests/65 which specifically adds support for the
org.freedesktop.portal.OpenURI.OpenFileD-Bus methodAdditional context in #160923
cc: @LunNova
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)