Skip to content

libdeflate: fix darwin build#217067

Merged
viraptor merged 1 commit intoNixOS:staging-nextfrom
viraptor:libdeflate-darwin
Feb 19, 2023
Merged

libdeflate: fix darwin build#217067
viraptor merged 1 commit intoNixOS:staging-nextfrom
viraptor:libdeflate-darwin

Conversation

@viraptor
Copy link
Contributor

Description of changes

Calling futimens requires building with SDK 11.0.

Fixes issue raised by @vcunat in #216181 (comment)

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Calling `futimens` requires building with SDK 11.0.
@ofborg ofborg bot added 6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Feb 19, 2023
@viraptor viraptor merged commit f6f365e into NixOS:staging-next Feb 19, 2023
@viraptor viraptor deleted the libdeflate-darwin branch February 19, 2023 05:18
@vcunat vcunat mentioned this pull request Feb 19, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant