Skip to content

ruby_3_0: fix build on darwin#217024

Merged
vcunat merged 1 commit intoNixOS:staging-nextfrom
marsam:staging-next
Feb 19, 2023
Merged

ruby_3_0: fix build on darwin#217024
vcunat merged 1 commit intoNixOS:staging-nextfrom
marsam:staging-next

Conversation

@marsam
Copy link
Contributor

@marsam marsam commented Feb 18, 2023

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Feb 18, 2023
@github-actions github-actions bot added the 6.topic: ruby A dynamic, open source programming language with a focus on simplicity and productivity. label Feb 18, 2023
@marsam marsam mentioned this pull request Feb 18, 2023
Merged
6 tasks
@ofborg ofborg bot requested review from manveru and vrthra February 18, 2023 23:14
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. labels Feb 18, 2023
viraptor
viraptor approved these changes Feb 19, 2023
View reviewed changes
Copy link
Contributor

@viraptor viraptor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me.

@vcunat vcunat merged commit c984977 into NixOS:staging-next Feb 19, 2023
@marsam marsam deleted the staging-next branch May 31, 2023 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@viraptor viraptor viraptor approved these changes

@manveru manveru Awaiting requested review from manveru

@vrthra vrthra Awaiting requested review from vrthra

Assignees

No one assigned

Labels

6.topic: darwin Running or building packages on Darwin 6.topic: ruby A dynamic, open source programming language with a focus on simplicity and productivity. 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@marsam @viraptor @vcunat