Skip to content

Comments

Revert "tbb: split output"#216842

Closed
Artturin wants to merge 1 commit intoNixOS:masterfrom
Artturin:revertsplittbb
Closed

Revert "tbb: split output"#216842
Artturin wants to merge 1 commit intoNixOS:masterfrom
Artturin:revertsplittbb

Conversation

@Artturin
Copy link
Member

This reverts commit f386825.

broke various cmake builds

embree openimagedenoise

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

This reverts commit f386825.

broke various cmake builds

embree openimagedenoise
@hesiod
Copy link
Contributor

hesiod commented Feb 17, 2023

@Artturin I don't think this is necessary, I already have a trivial fix for #216390 ready

Edit: See #216844

@ofborg ofborg bot requested a review from thoughtpolice February 17, 2023 19:32
@ofborg ofborg bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. labels Feb 17, 2023
@Artturin Artturin closed this Feb 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants