ceres-solver: Add and propagate metis dependency#216399
Merged
davidak merged 1 commit intoNixOS:masterfrom Mar 1, 2023
Merged
Conversation
SuiteSparse depends on METIS anyway, so we might as well enable METIS in ceres-solver as well.
This was referenced Feb 15, 2023
Merged
Draft
ofborg
bot
added
10.rebuild-darwin: 1-10
Member
|
Result of 1 package failed to build:
10 packages built:
rtabmap build also fails on master (#216919) |
davidak
approved these changes
Feb 18, 2023
Member
davidak
left a comment
davidak
left a comment
There was a problem hiding this comment.
Change looks good
Build successful
Member
|
cc maintainer @giogadi |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
SuiteSparse (5, not 4.2/4.4) depends on METIS anyway, so we might as well enable METIS in ceres-solver as well.
Part of an ongoing effort to package Meshroom (#94127). See also #215528 #215728
Note:
ceres-solverwill enable additional features based on Eigen's MetisSupport if it detects Metis.Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)