binutils: try to move headers around only when --host/--target differ#215989
Merged
yu-re-ka merged 1 commit intoNixOS:staging-nextfrom Feb 12, 2023
Merged
binutils: try to move headers around only when --host/--target differ#215989yu-re-ka merged 1 commit intoNixOS:staging-nextfrom
yu-re-ka merged 1 commit intoNixOS:staging-nextfrom
Conversation
Without the change `pkgsMusl.pkgsStatic.buildPackages.binutils.bintools`
build fails as:
$ ln: failed to create symbolic link './include': File exists
This happens because both host and target are `x86_64-unknown-linux-musl`.
But `hostPlatform` differs from `targetPlatform` by `isStatic` value.
By `./configure`'s standard it's not yet a cross-compilation. The change
tries to move things around only when tuples change.
13 tasks
Contributor
|
Can confirm this diff fixes the build failure of |
yu-re-ka
approved these changes
Feb 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without the change
pkgsMusl.pkgsStatic.buildPackages.binutils.bintoolsbuild fails as:This happens because both host and target are
x86_64-unknown-linux-musl. ButhostPlatformdiffers fromtargetPlatformbyisStaticvalue.By
./configure's standard it's not yet a cross-compilation. The change tries to move things around only when tuples change.Description of changes
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)