Skip to content

gtest: ensure C++17 support for aarch64#215767

Merged
veprbl merged 1 commit intostagingfrom
pr/gtest_cxx17_aarch64
Feb 13, 2023
Merged

gtest: ensure C++17 support for aarch64#215767
veprbl merged 1 commit intostagingfrom
pr/gtest_cxx17_aarch64

Conversation

@veprbl
Copy link
Member

@veprbl veprbl commented Feb 11, 2023

Description of changes

Follow up on #207338
This is needed to fix arrow-cpp after #213324

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from ivan-tkatchev February 11, 2023 05:35
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Feb 11, 2023
@veprbl veprbl merged commit 938a52f into staging Feb 13, 2023
@wegank wegank deleted the pr/gtest_cxx17_aarch64 branch February 28, 2023 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant