Skip to content

nix-your-shell: init at 1.0.1#215733

Merged
figsoda merged 2 commits intoNixOS:masterfrom
9999years:nix-your-shell
Feb 12, 2023
Merged

nix-your-shell: init at 1.0.1#215733
figsoda merged 2 commits intoNixOS:masterfrom
9999years:nix-your-shell

Conversation

@9999years
Copy link
Contributor

@9999years 9999years commented Feb 10, 2023

Description of changes

An any-nix-shell alternative with support for nix develop / flakes.

https://github.com/MercuryTechnologies/nix-your-shell

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

9999years
9999years commented Feb 10, 2023
View reviewed changes
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Feb 10, 2023
figsoda
figsoda suggested changes Feb 11, 2023
View reviewed changes
figsoda
figsoda reviewed Feb 11, 2023
View reviewed changes
Copy link
Member

@figsoda figsoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missed it on the first review, this might be why nix-update-script didn't work

@9999years
Copy link
Contributor Author

9999years commented Feb 11, 2023 •
edited
Loading

I tried again but nix-update-script still doesn't correctly update cargoSha256 (it just uses the same hash as the source, which fails at build-time). I got the version format updated though and fixed the update script to work correctly with the new format.

@figsoda
Copy link
Member

figsoda commented Feb 11, 2023 •
edited
Loading

I am not able to reproduce this, can you show me what your setup is where that happened?

Maybe it is because you had sha256 and cargoSha256 set to the same value, nix-update only does plain text replacements and can't handle that

@9999years
Copy link
Contributor Author

9999years commented Feb 12, 2023

Yeah, I'd cleared out both values. The upstream repo doesn't have other tags so there's not other values to try... I'm happy to set it to nix-update-script if you're sure it'll work.

@figsoda
Copy link
Member

figsoda commented Feb 12, 2023

you can set them to any invalid hash by e.g. changing one character, it should work as long as they are different

@9999years
Copy link
Contributor Author

9999years commented Feb 12, 2023

OK yeah, I tried that and it worked. Pushed a change to use nix-update-script. Thanks for the help debugging.

@figsoda figsoda mentioned this pull request Feb 12, 2023
Merged
12 tasks
figsoda
figsoda approved these changes Feb 12, 2023
View reviewed changes
Copy link
Member

@figsoda figsoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@figsoda figsoda merged commit b71a0e4 into NixOS:master Feb 12, 2023
@9999years 9999years deleted the nix-your-shell branch February 12, 2023 20:37
@9999years 9999years mentioned this pull request Mar 4, 2025
Open
@phaer phaer mentioned this pull request Mar 21, 2025
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Gabriella439 Gabriella439 Gabriella439 approved these changes

+1 more reviewer

@figsoda figsoda figsoda approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@9999years @figsoda @Gabriella439