inputDerivation: support structuredAttrs#215173
Closed
roberth wants to merge 1 commit intoNixOS:masterfrom
Closed
Conversation
This was referenced Feb 7, 2023
ofborg
bot
added
10.rebuild-darwin: 0
roberth
force-pushed
the
inputDerivation-structuredAttrs
branch
from
c19aaf2 to
b44502b
Compare
Member
Author
There's a performance cost associated with largely unused attributes like this one, so without a reason for this to be an attribute, I think it's better to remove it. Alternatively, we could replace it by a The difference is that the customization of |
wegank
added
2.status: stale
stale
bot
removed
the
2.status: stale
wegank
added
the
2.status: stale
4 tasks
13 tasks
Contributor
|
Superseded by #361233 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Draft solution. I think we'll want to route
coreutilsinto here, so we canmkdirand get rid ofdog.#206728 also happens to route more stuff into here, so I think we should perhaps just bring a
pkgsinto scope, so as not to duplicate too many things. Downside is a potential infinite recursion comes into scope, but using file structure to "enforce" a lack of those is probably not the best strategy.inputDerivationondisallowedReferences#215168Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes