Skip to content

chez-racket: support many more platforms#214779

Merged
Ericson2314 merged 2 commits intoNixOS:stagingfrom
alyssais:chez-racket-bsd
Feb 5, 2023
Merged

chez-racket: support many more platforms#214779
Ericson2314 merged 2 commits intoNixOS:stagingfrom
alyssais:chez-racket-bsd

Conversation

@alyssais
Copy link
Member

@alyssais alyssais commented Feb 5, 2023

Description of changes

See commit messages.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@alyssais alyssais added the 6.topic: portability General portability concerns, not specific to cross-compilation or a specific platform label Feb 5, 2023
@alyssais alyssais requested a review from Ericson2314 February 5, 2023 16:26
I split out architecture and operating system, since the values don't
depend on each other, and this saves a lot of repetition.
libiconv is already defined per-platform.  The actual libiconv library
won't be built on platforms like Linux where it doesn't need to be, so
there's no need to maintain a separate platform list here.

Required to build for FreeBSD.
@ofborg ofborg bot requested a review from L-as February 5, 2023 17:03
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Feb 5, 2023
@Ericson2314 Ericson2314 merged commit 2f063f0 into NixOS:staging Feb 5, 2023
@L-as
Copy link
Member

L-as commented Feb 5, 2023

Maybe it would make sense to update the version too? It's ancient at this point.

@alyssais alyssais deleted the chez-racket-bsd branch February 5, 2023 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: portability General portability concerns, not specific to cross-compilation or a specific platform 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants