make-squashfs,make-iso9660-image: use __structuredAttrs#214373
Merged
ncfavier merged 2 commits intoNixOS:masterfrom May 18, 2023
Merged
make-squashfs,make-iso9660-image: use __structuredAttrs#214373ncfavier merged 2 commits intoNixOS:masterfrom
__structuredAttrs#214373ncfavier merged 2 commits intoNixOS:masterfrom
Conversation
github-actions
bot
added
the
6.topic: nixos
2 tasks
ofborg
bot
added
10.rebuild-darwin: 0
alyssais
reviewed
May 10, 2023
ncfavier
force-pushed
the
make-image-structured-attrs
branch
from
d684c55 to
b0a1c2b
Compare
alyssais
reviewed
May 11, 2023
ncfavier
force-pushed
the
make-image-structured-attrs
branch
from
b0a1c2b to
5d352b2
Compare
Makes it easier to enable discarding of references, a feature of Nix 2.14 which requires structured attrs.
Makes it easier to enable discarding of references, a feature of Nix 2.14 which requires structured attrs.
ncfavier
force-pushed
the
make-image-structured-attrs
branch
from
5d352b2 to
ea81a24
Compare
alyssais
approved these changes
May 13, 2023
Member
|
@ofborg eval |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes it easier to enable discarding of references, an upcoming feature of Nix which requires structured attrs.
This also makes the builder for make-iso9660-image more robust since we can pass proper arrays instead of space-separated strings.
For reference,
__structuredAttrsis supported since Nix 2.0 and nixpkgs #175649.