Skip to content

python310Packages.eventlet: disable test_fork_after_monkey_patch test…#213788

Merged
superherointj merged 1 commit intoNixOS:stagingfrom
SuperSandro2000:eventlet-march
Feb 13, 2023
Merged

python310Packages.eventlet: disable test_fork_after_monkey_patch test…#213788
superherointj merged 1 commit intoNixOS:stagingfrom
SuperSandro2000:eventlet-march

Conversation

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Jan 31, 2023

… all the time

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Jan 31, 2023
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches. labels Jan 31, 2023
@superherointj
Copy link
Contributor

superherointj commented Feb 8, 2023

I think this should target staging. Tried to build it and and gave up.

@superherointj
Copy link
Contributor

superherointj commented Feb 9, 2023 •
edited
Loading

Hi @SuperSandro2000,
Sorry to disturb you again.
I think this PR is important because seems to be leading to a lot of things to fail:
image
(I have not tested if all packages failing are because of this, but likely. Anyway, my point here is just to proceed with this PR.)

IMO this should be merged to staging.

Can you change the branch to staging? (So I can happily approve & merge it. :-)

@superherointj superherointj mentioned this pull request Feb 9, 2023
Closed
@SuperSandro2000 SuperSandro2000 changed the base branch from master to staging February 12, 2023 22:46
@superherointj
Copy link
Contributor

superherointj commented Feb 13, 2023

Thanks Sandro!

@superherointj superherointj merged commit ca784e0 into NixOS:staging Feb 13, 2023
@SuperSandro2000 SuperSandro2000 deleted the eventlet-march branch February 15, 2023 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

1 more reviewer

@superherointj superherointj superherointj approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@SuperSandro2000 @superherointj