Skip to content

Comments

gsl,tbb: split output#212787

Merged
Artturin merged 4 commits intoNixOS:stagingfrom
Artturin:splitthings2
Jan 31, 2023
Merged

gsl,tbb: split output#212787
Artturin merged 4 commits intoNixOS:stagingfrom
Artturin:splitthings2

Conversation

@Artturin
Copy link
Member

@Artturin Artturin commented Jan 26, 2023 •
edited
Loading

found with
nix path-info -r /run/current-system | xargs -i fd --type d --full-path 'include/' {} | rg -v "\-dev" | xargs du -shc --apparent-size | sort -hk1

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@Artturin Artturin added the 6.topic: closure size The final size of a derivation, including its dependencies label Jan 26, 2023
@Artturin Artturin changed the title tbb: split output gsl,tbb: split output Jan 26, 2023
@ofborg ofborg bot requested a review from thoughtpolice January 26, 2023 15:38
@ofborg ofborg bot added 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. labels Jan 26, 2023
@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Jan 26, 2023
@ofborg ofborg bot requested review from edwtjo and markuskowa January 26, 2023 16:37
@Artturin
Copy link
Member Author

Artturin commented Jan 26, 2023

other large include dirs

nix path-info -r /run/current-system | xargs -i fd --type d --full-path 'include/' {} | rg -v "\-dev" | xargs du -shc --apparent-size | sort -hk1

389K    /nix/store/3bvlq0akai4x89jsn2dlvlikk27r93zi-libplacebo-4.208.0/include/libplacebo/
393K    /nix/store/rv6badsn64d17accb2iwkxfqngx7k2as-libbpf-1.1.0/include/linux/
398K    /nix/store/6d9cdiv9dlg635wfazr1bh4x5x4sq5jx-rocm-llvm-llvm-5.4.2/include/llvm-c/
411K    /nix/store/znwrpnp8dlh3b9zpgpm1i7c4nb51z93f-libvirt-8.10.0/include/libvirt/
432K    /nix/store/awylv4dyczcwa4qy9fx06nc87pbb72kd-aws-c-common-0.8.9/include/aws/
446K    /nix/store/lpir61yxxjhymlxy74ycgxqfdr86yjys-qca-qt5-2.3.4/include/Qca-qt5/
469K    /nix/store/3bfvwjayikvaz17lba8794bjvxm58nz8-modemmanager-1.18.12/include/libmm-glib/
480K    /nix/store/k45cjwh35qx1bdl4clg6mq6i0kxl3p8a-rocm-runtime-5.4.1/include/hsa/
509K    /nix/store/31idnad0cg2jhv5qs6y7fq5aw8q9g7g0-libyuv-1787/include/libyuv/
547K    /nix/store/zzwqcifb2hgm1qii6ixh86cjryzlf5zh-linux-headers-6.1/include/drm/
631K    /nix/store/yyahnn0xnwcshm8a21zqgg5b4pca7z7f-rocm-llvm-llvm-5.4.2/include/sanitizer/
638K    /nix/store/g9qkr3ncgh27kwsynq03r75amd9i7fwj-sqlcipher-4.5.3/include/sqlcipher/
645K    /nix/store/hyfid0yaiqgdp0hjy0z5xf85v0dqrp7h-taglib-1.13/include/taglib/
725K    /nix/store/abax98471z8fshv4b9p46bkh3lxmpy0z-python3-3.10.9/include/python3.10/
773K    /nix/store/fvgl8js6f2ig5f2w3m746ya8jzza1ihz-directfb-1.7.7/include/directfb-internal/
841K    /nix/store/kg6qk2qrjvfhqyhkmgvi1h193fj48qc3-rocm-opencl-runtime-5.4.2/include/CL/
852K    /nix/store/fvgl8js6f2ig5f2w3m746ya8jzza1ihz-directfb-1.7.7/include/directfb/
887K    /nix/store/ykm2v353pwr9yyj4vpgqxbncn3r6d56a-nlohmann_json-3.11.2/include/nlohmann/
912K    /nix/store/b19kysh00skk7n8fn676q69sxn5v2qhq-python3.10-mypy-0.991/lib/python3.10/site-packages/mypyc/external/googletest/include/gtest/
1.1M    /nix/store/w90327cv9z2q6czjhzsfh7hs3fa8hs71-libsigc++-2.10.8/include/sigc++-2.0/
1.2M    /nix/store/fpyyvrmgpv9ggawnfa8i8zckmpqp79jq-xorgproto-2021.5/include/X11/
1.2M    /nix/store/nlc8fv3a5r2vr1vq07y5qw6riz7d6v8h-gsl-2.7.1/include/gsl/
1.8M    /nix/store/hcbalan0xq30hb53myvw93i309ifh4yg-tbb-2020.3/include/tbb/
2.5M    /nix/store/hr6kxafywg7ar3gpfjzplgzxcr31g23w-zfs-kernel-2.1.7-6.0.19/src/zfs-2.1.7/include/sys/
2.8M    /nix/store/7y1qagav6xv4k3w0df5d7z91y2d3w4z7-nodejs-18.13.0/include/node/
2.8M    /nix/store/g57a0hbcvx6ph0a144s0fq0n0j2pqww6-protobuf-3.21.12/include/google/
3.8M    /nix/store/zadsncz62r5nd6wfsw77754lva7hzqvq-opencv-3.4.18/include/opencv2/
4.5M    /nix/store/zzwqcifb2hgm1qii6ixh86cjryzlf5zh-linux-headers-6.1/include/linux/
5.2M    /nix/store/5wb6fwc2g1f1pjq5hasnlz7y64b8g7by-msgpack-3.3.0/include/msgpack/
6.1M    /nix/store/yyahnn0xnwcshm8a21zqgg5b4pca7z7f-rocm-llvm-llvm-5.4.2/include/c++/
6.8M    /nix/store/j38c32v53zmn3ipy9cc5g806fyxc5fvv-opencv-4.7.0/include/opencv4/
11M     /nix/store/z1yw9cw97bcdfmxz5wk7j1bycw42r1mw-gcc-11.3.0/include/c++/
18M     /nix/store/9c4r6fcn5h15l1hzywf7w8aaqyvd9fhi-rocm-llvm-clang-5.4.2/include/clang/
21M     /nix/store/6d9cdiv9dlg635wfazr1bh4x5x4sq5jx-rocm-llvm-llvm-5.4.2/include/llvm/

@Artturin Artturin marked this pull request as ready for review January 27, 2023 15:06
@markuskowa
Copy link
Member

markuskowa commented Jan 30, 2023 •
edited
Loading

@GrahamcOfBorg build cp2k d-seams

@Artturin
Copy link
Member Author

Artturin commented Jan 30, 2023 •
edited
Loading

@markuskowa both build for me locally, are those just 2 packages you picked randomly or have they had issues when gsl/tbb have been updated, if so then i can add them to passthru.tests

@markuskowa
Copy link
Member

markuskowa commented Jan 30, 2023

Yep, works for me too locally.
Those are two packages I care about, that's why checked them.
Good to merge from my side.

jtojnar
jtojnar reviewed Jan 30, 2023
View reviewed changes
@Artturin
tbb: split output
f386825 
$ nix build ".#tbb" && nix path-info ".#tbb^*" --json | jq '.[] | .path, .narSize'

"/nix/store/pz9868iam3dklx9bdwhhlzjf71j27gwi-tbb-2020.3-dev"
1901872 # 1.9M
"/nix/store/rqgy93yzg9lhdnvmwbcmywa7x7asx4rg-tbb-2020.3"
563520 # 551K
@Artturin
gsl: split output
092c2b3 
$ nix build ".#gsl" && nix path-info ".#gsl^*" --json | jq '.[] | .path, .narSize'

"/nix/store/jlbk4k5wgb1p9yy501p4pymazslfnsc0-gsl-2.7.1"
6103816 # 5.9M
"/nix/store/vgxhxw9if83ffxj0alv4mpi982ypcsbb-gsl-2.7.1-dev"
1272264 # 1.3M
@Artturin
python310Packages.cvxopt: use lib.getX
c0548dd
@Artturin
octopus: use lib.getX
37dede4
edwtjo
edwtjo approved these changes Jan 30, 2023
View reviewed changes
Copy link
Member

@edwtjo edwtjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ofborg ofborg bot requested review from edwtjo and markuskowa January 30, 2023 17:55
@Artturin Artturin requested a review from jtojnar January 30, 2023 19:04
@Artturin Artturin merged commit 3e3c0cf into NixOS:staging Jan 31, 2023
@Artturin Artturin deleted the splitthings2 branch January 31, 2023 13:58
This was referenced Feb 17, 2023
Merged
Closed
This was referenced Feb 17, 2023
Closed
Merged
@davidak davidak mentioned this pull request Feb 17, 2023
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@markuskowa markuskowa Awaiting requested review from markuskowa

@edwtjo edwtjo Awaiting requested review from edwtjo

@jtojnar jtojnar Awaiting requested review from jtojnar

Assignees

No one assigned

Labels

6.topic: closure size The final size of a derivation, including its dependencies 6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Artturin @markuskowa @edwtjo @jtojnar