handbrake: 1.5.1 -> 1.6.1#212306
Conversation
8864814 to
cf6c32c
Compare
|
this runs fine for me on x86_64-linux (wayland/sway), but the new svt-avt package input added in this patch breaks the aarch64-linux build in a new way: $ nix build '.#legacyPackages.aarch64-linux.handbrake'
error: Package ‘svt-av1-1.4.1’ in /nix/store/1w97dryirwh60407sg97x521m0aisln4-source/pkgs/tools/video/svt-av1/default.nix:31 is marked as broken, refusing to evaluate.ffmpeg-full special-cases a few dependencies, presumably to work around platform-specific issues like this: ffmpeg-full = callPackage ../development/libraries/ffmpeg-full {
svt-av1 = if stdenv.isAarch64 then null else svt-av1;
rtmpdump = null; # Prefer the built-in RTMP implementation
# The following need to be fixed on Darwin
libjack2 = if stdenv.isDarwin then null else libjack2;
libmodplug = if stdenv.isDarwin then null else libmodplug;
libmfx = if stdenv.isDarwin then null else intel-media-sdk;
libpulseaudio = if stdenv.isDarwin then null else libpulseaudio;
samba = if stdenv.isDarwin then null else samba;
inherit (darwin.apple_sdk.frameworks)
Cocoa CoreServices CoreAudio AVFoundation MediaToolbox
VideoDecodeAcceleration VideoToolbox;
};i guess if you want to ditch it maybe you have to replicate some of that? |
|
The problem here is that svt-av1 is a dependency of handbrake, not ffmpeg. So setting svt-av1 to |
Readd when NixOS/nixpkgs#212306 gets merged.
|
If the package now requires svt-avt and that does not work on aarch64-linux that is unfortunate but I don't think we can do anything here unless we find some patch upstream or ask them for help. |
Additionaly, use the ffmpeg patches from upstream and bump ffmpeg version to 5.1. Fixes NixOS#211297
|
I agree with Sandro here. @uninsane svt-av1 was marked as broken 2 years ago, can you try if a new version fixed the issue on aarch64 and nixpkgs just forgot to set broken to false? I don't have aarch64 hardware, so i can't test. |
|
it’ll be 3-4 days before i get a chance to do that, but yeah if nobody beats me to it i’ll look into the svt-av1 stuff 👍
you might also try cross-compiling: you can probably tell a lot here without actually deploying/running it on HW. handbrake with broken-at-runtime AV1 on aarch64 would still be much better than handbrake uncompilable for aarch64.
… On Feb 1, 2023, at 21:57, laalsaas ***@***.***> wrote:
I agree with Sandro here.
@uninsane svt-av1 was marked as broken 2 years ago, can you try if a new version fixed the issue on aarch64 and nixpkgs just forgot to set broken to false? I don't have aarch64 hardware, so i can't test.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.
|
Cross compiling svt-av1 for aarch64 works just fine. It think that you can just remove this: |
|
darwin aarch64 is still broken but that might be related to the apple SDK. It didn't work before so that is fine |
f56e62c to
c774708
Compare
Fixes #211297
Description of changes
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes