Skip to content

Misc changes#212123

Merged
AndersonTorres merged 2 commits intoNixOS:masterfrom
atorres1985-contrib:misc-updates
Jan 25, 2023
Merged

Misc changes#212123
AndersonTorres merged 2 commits intoNixOS:masterfrom
atorres1985-contrib:misc-updates

Conversation

@AndersonTorres
Copy link
Member

@AndersonTorres AndersonTorres commented Jan 22, 2023 •
edited
Loading

  • wallutils: 5.12.4 -> 5.12.5
  • castxml: run nixpkgs-format
Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jan 22, 2023
wegank
wegank reviewed Jan 24, 2023
View reviewed changes
@AndersonTorres
wallutils: 5.12.4 -> 5.12.5
e9c4598 
Also, add myself as maintainer.
@AndersonTorres
castxml: run nixpkgs-fmt
f4bc305 
As suggested by RFC 101.
hugosenari
hugosenari reviewed Jan 25, 2023
View reviewed changes
pkgs/tools/graphics/wallutils/default.nix
license = lib.licenses.bsd3;
maintainers = [ lib.maintainers.AndersonTorres ];
inherit (wayland.meta) platforms;
badPlatforms = lib.platforms.darwin;
Copy link

@hugosenari hugosenari Jan 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Copy link
Member Author

@AndersonTorres AndersonTorres Jan 25, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no donut for you

@AndersonTorres AndersonTorres changed the title wallutils: 5.12.4 -> 5.12.5 Misc changes Jan 25, 2023
@AndersonTorres AndersonTorres merged commit c2aa912 into NixOS:master Jan 25, 2023
@AndersonTorres AndersonTorres deleted the misc-updates branch January 25, 2023 16:37
@wegank wegank mentioned this pull request Feb 6, 2023
Closed
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wegank wegank wegank approved these changes

+2 more reviewers

@hugosenari hugosenari hugosenari approved these changes

@superherointj superherointj superherointj approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@AndersonTorres @hugosenari @superherointj @wegank