[RFC 140 2b] `pkgs/by-name`: Automated migration by infinisil · Pull Request #211832 · NixOS/nixpkgs

infinisil · 2023-01-20T21:44:43Z

Context

This is the second part of the implementation of the accepted RFC 140, the automated migration. The first part is already done and can be found here: #237439.

The plan for the second part can be found here: #258650

This is hopefully only the first of many quality-of-life improvements to Nixpkgs by the Nixpkgs Architecture Team.

This PR is currently an old draft of the implementation, using a slightly hacky tool to do it. Will be updated after part 1 is done.

TODO

Update the manual migration guidelines added in pkgs/by-name: Add manual migration guidelines #254632

zowoq · 2023-01-20T22:58:52Z

[skip editorconfig] should help with this.

infinisil · 2023-01-20T23:08:46Z

@zowoq Not entirely how that works, see here, but that can't disable just a specific workflow, it disables all of them which I don't want

zowoq · 2023-01-20T23:12:45Z

nixpkgs/.github/workflows/editorconfig.yml

Line 14 in 31ce2fc

    
           if: "github.repository_owner == 'NixOS' && !contains(github.event.pull_request.title, '[skip editorconfig]')"

[skip editorconfig] in the PR title skips only the editorconfig check

NixOS#211832 broke the workflows for all PR's temporarily because it runs into GitHub API limits. This change to the workflow files just makes sure that the problematic workflows don't run for that specific PR.

pkgs/top-level/stage.nix

Makes the build independency of the default.nix and update.sh file by explicitly specifying the files that are needed in the result This allows changing those files without causing a rebuild

This way, changing the Nix file won't change the derivation

Using nixpkgs-architecture/nix-spp@94a4f56

Tested with nix-env -qaf . The res -> super changes are necessary because res points to the result of the current overlay, but some of the packages were moved to the previous overlay, which can be accessed with super. This is a fundamental problem to be fixed, see NixOS#55061 and related issues The schleuder change is necessary because the ./default.nix file referenced ./., but there's also another package in ./bin. The tool couldn't move the gemfiles in ./. because The schleuder change is necessary because the tool isn't smart enough and this is a special case of the default.nix reading gemfiles from a ./. reference and there being both schleuder in pkgs/tools/security/schleuder and schleuder-cli in pkgs/tools/security/schleuder/cli

nixos-discourse · 2023-01-24T00:18:04Z

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/2022-01-23-nixpkgs-architecture-team-meeting-26/24892/1

pkgs/top-level/stage.nix

infinisil · 2023-09-23T00:48:31Z

I'm planning to implement this in a series of steps: #258650

iFreilicht · 2023-10-30T11:00:27Z

.github/workflows/backport.yml

      contents: write # for korthout/backport-action to create branch
      pull-requests: write # for korthout/backport-action to create PR to backport
    name: Backport Pull Request
-    if: github.repository_owner == 'NixOS' && github.event.pull_request.merged == true && (github.event_name != 'labeled' || startsWith('backport', github.event.label.name))


I think this should be changed back after this PR has been merged, otherwise this workflow might run in every contributors repo as well, right?

Oh yeah I only used this for testing. I'll have to completely update this PR once everything is ready.

nixos-discourse · 2024-01-10T22:29:25Z

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/ci-will-soon-enforce-pkgs-by-name-for-new-packages/38098/1

gaykitty · 2024-08-06T02:58:08Z

FYI the Nixpkgs Architecture Team link is incorrect or dead.

infinisil · 2024-11-21T19:10:33Z

Note that @Aleksanaa did a large part of the automated migration in #354531, thank you! There's still more that can be migrated manually, so I'll leave this PR open for now until I or somebody else can do it

nixos-discourse · 2025-06-02T23:20:55Z

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/a-look-at-nixos-nixpkgs-evaluation-times-over-the-years/65114/13

infinisil force-pushed the auto-calling branch from cfc6b31 to 550c1db Compare January 20, 2023 21:46

infinisil mentioned this pull request Jan 20, 2023

HttpError: API rate limit exceeded actions/labeler#448

Closed

infinisil changed the title ~~Nixpkgs Architecture Team: Simple Package Paths RFC draft implementation test~~ Nixpkgs Architecture: Simple Package Paths RFC draft implementation test Jan 20, 2023

infinisil force-pushed the auto-calling branch from 550c1db to fef9e79 Compare January 20, 2023 22:44

zowoq changed the title ~~Nixpkgs Architecture: Simple Package Paths RFC draft implementation test~~ Nixpkgs Architecture: Simple Package Paths RFC draft implementation test [skip editorconfig] Jan 20, 2023

ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jan 20, 2023

github-actions bot added the 6.topic: policy discussion Discuss policies to work in and around Nixpkgs label Jan 20, 2023

infinisil mentioned this pull request Jan 20, 2023

.github/workflows: Don't run problematic ones for #211832 #211844

Closed

zowoq changed the title ~~Nixpkgs Architecture: Simple Package Paths RFC draft implementation test [skip editorconfig]~~ Nixpkgs Architecture: Simple Package Paths RFC draft implementation test [skip treewide] Jan 20, 2023

SuperSandro2000 reviewed Jan 22, 2023

View reviewed changes

pkgs/top-level/stage.nix Outdated Show resolved Hide resolved

infinisil force-pushed the auto-calling branch 3 times, most recently from a06330e to 35c73e4 Compare January 23, 2023 22:07

ofborg bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Jan 23, 2023

infinisil added 5 commits January 24, 2023 00:59

documentation-highlighter: Only depend on needed files

f6e5ea8

Makes the build independency of the default.nix and update.sh file by explicitly specifying the files that are needed in the result This allows changing those files without causing a rebuild

zsh-clipboard: Make independent of Nix file

d66bed8

This way, changing the Nix file won't change the derivation

Implement unit directory reading

b0b8993

Run automatic migration

24ce478

Using nixpkgs-architecture/nix-spp@94a4f56

infinisil force-pushed the auto-calling branch from 35c73e4 to 5727203 Compare January 24, 2023 00:00

ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Jan 24, 2023

This was referenced Jan 24, 2023

{documentation-highlighter,zsh-clipboard}: Remove dependency on Nix files #212336

Merged

github actions: skip treewide PRs #211845

Merged

AndersonTorres reviewed Jan 27, 2023

View reviewed changes

pkgs/top-level/stage.nix Show resolved Hide resolved

This was referenced Sep 11, 2023

treewide: migrate packages to by-name hierarchy #254417

Merged

pkgs/by-name: Add manual migration guidelines #254632

Merged

infinisil added this to the RFC 140 milestone Sep 11, 2023

iFreilicht reviewed Oct 30, 2023

View reviewed changes

This was referenced Nov 7, 2023

gtkcord4: 0.0.12 -> 0.0.16-1 #259394

Merged

spip: init at unstable-2023-04-19 #247476

Merged

infinisil changed the title ~~[RFC 140] Simple package paths, part 2: Automated migration~~ [RFC 140 2b] pkgs/by-name: Automated migration Dec 20, 2023

infinisil mentioned this pull request Jan 5, 2024

RFC 140 migration plan #258650

Open

infinisil mentioned this pull request Jan 30, 2024

tests.nixpkgs-check-by-name: Syntactic callPackage detection and allow new package variants #285089

Merged

Scrumplex mentioned this pull request Mar 14, 2024

opencomposite: unstable-2024-02-16 -> unstable-2024-03-04 #295796

Merged

wegank added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Mar 19, 2024

AndersonTorres mentioned this pull request Apr 4, 2024

Feature request: new meta attr for source code repository #293838

Open

3 tasks

infinisil mentioned this pull request Apr 15, 2024

Extend to not just pkgs/by-name NixOS/nixpkgs-vet#45

Open

infinisil mentioned this pull request Apr 22, 2024

Implement automated migrations NixOS/nixpkgs-vet#56

Open

amesgen mentioned this pull request May 3, 2024

treewide: move packages maintained by lucperkins to pkgs/by-name #308863

Merged

13 tasks

drupol mentioned this pull request Aug 5, 2024

haxe: 4.3.4 -> 4.3.5 #332277

Merged

13 tasks

AndersonTorres mentioned this pull request Aug 10, 2024

smc-fuzzer: init at 0-unstable-2020-12-23 #332586

Merged

13 tasks

stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Sep 6, 2024

eclairevoyant mentioned this pull request Sep 7, 2024

libjaylink: Move package definition into by-name directory #338675

Merged

13 tasks

lelgenio mentioned this pull request Sep 29, 2024

angular-language-server: init at 18.2.0 #343326

Closed

13 tasks

musjj mentioned this pull request Oct 8, 2024

fcitx5-mozc: 2.26.4220.102 -> 2.30.5544.102 #346680

Merged

13 tasks

GaetanLepage mentioned this pull request Nov 21, 2024

treewide: move to by-name #357828

Merged

13 tasks

wegank added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jan 2, 2025

stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 2, 2025

nixpkgs-ci bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Nov 30, 2025

Uh oh!

Comments

Conversation

infinisil commented Jan 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Context

TODO

Uh oh!

zowoq commented Jan 20, 2023

Uh oh!

infinisil commented Jan 20, 2023

Uh oh!

zowoq commented Jan 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

nixos-discourse commented Jan 24, 2023

Uh oh!

Uh oh!

infinisil commented Sep 23, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

iFreilicht Oct 30, 2023

Choose a reason for hiding this comment

Uh oh!

infinisil Oct 30, 2023

Choose a reason for hiding this comment

Uh oh!

nixos-discourse commented Jan 10, 2024

Uh oh!

gaykitty commented Aug 6, 2024

Uh oh!

infinisil commented Nov 21, 2024

Uh oh!

nixos-discourse commented Jun 2, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

infinisil commented Jan 20, 2023 •

edited

Loading

zowoq commented Jan 20, 2023 •

edited

Loading

infinisil commented Sep 23, 2023 •

edited

Loading