Skip to content

Comments

nix-doc: 0.5.5 -> 0.5.6#211310

Merged
zowoq merged 1 commit intoNixOS:masterfrom
lf-:jade/update-nix-doc
Jan 18, 2023
Merged

nix-doc: 0.5.5 -> 0.5.6#211310
zowoq merged 1 commit intoNixOS:masterfrom
lf-:jade/update-nix-doc

Conversation

@lf-
Copy link
Member

@lf- lf- commented Jan 18, 2023

Description of changes

I updated nix-doc to also be compatible with nix 1.13, and added integration tests to ensure the plugin does actually work.

lf-/nix-doc@3f1a551

I added nix to nativeBuildInputs for this new integration tests functionality.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@lf- lf- mentioned this pull request Jan 18, 2023
13 tasks
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Jan 18, 2023
@zowoq zowoq merged commit c7e7050 into NixOS:master Jan 18, 2023
@zowoq
Copy link
Contributor

zowoq commented Jan 18, 2023

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants