Skip to content

Comments

nixVersions.nix_2_13: init at 2.13.1#211290

Merged
zowoq merged 4 commits intoNixOS:masterfrom
qowoz:nix213
Jan 20, 2023
Merged

nixVersions.nix_2_13: init at 2.13.1#211290
zowoq merged 4 commits intoNixOS:masterfrom
qowoz:nix213

Conversation

@zowoq
Copy link
Contributor

@zowoq zowoq commented Jan 17, 2023

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Jan 17, 2023
@zowoq zowoq requested a review from roberth January 17, 2023 22:10
@zowoq
Copy link
Contributor Author

zowoq commented Jan 17, 2023

cc

@adisbladis @Mic92 nix-eval-jobs
@lf- nix-doc

@lf-
Copy link
Member

lf- commented Jan 17, 2023 •
edited
Loading

Thank you for pinging me. I'll have a look. fyi: nix-doc depends on Nix for a Nix plugin, so i will try to get the update in asap because a pin would break its functionality.

@roberth roberth mentioned this pull request Jan 17, 2023
Merged
9 tasks
@lf-
Copy link
Member

lf- commented Jan 18, 2023

I have updated nix-doc so it will build with nix 2.13, as well as adding integration tests.

The update PR is here: #211310

Let's get the nix-doc update PR merged before updating Nix so people using the plugin won't have any issues :)

@zowoq zowoq marked this pull request as draft January 18, 2023 03:24
@zowoq zowoq changed the title nixVersions.nix_2_13: init at 2.13.0 nixVersions.nix_2_13: init at 2.13.1 Jan 18, 2023
@Mic92
Copy link
Member

Mic92 commented Jan 18, 2023

I have a look at nix-eval-jobs now.

@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Jan 18, 2023
@ofborg ofborg bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Jan 18, 2023
@zowoq zowoq marked this pull request as ready for review January 18, 2023 20:31
@zowoq
Copy link
Contributor Author

zowoq commented Jan 18, 2023

@ofborg build nix-doc

@zowoq
Copy link
Contributor Author

zowoq commented Jan 18, 2023

@lf- Looks like nix-doc is broken again with 2.13.1.

@lf-
Copy link
Member

lf- commented Jan 18, 2023

damn! I'll fix it in the next couple days.

@lf-
Copy link
Member

lf- commented Jan 19, 2023

@zowoq it looks like nix reverted one of the API changes in 2.13.1. I've fixed nix-doc upstream to support that as well, nixpkgs PR: #211499

@Mic92
Copy link
Member

Mic92 commented Jan 19, 2023

I did an rc1 release for nix-eval-jobs but there is still a double-free bug that I need to fix.

@zowoq
Copy link
Contributor Author

zowoq commented Jan 20, 2023 •
edited
Loading

I did an rc1 release for nix-eval-jobs but there is still a double-free bug that I need to fix.

@Mic92 Are you fine with merging this PR pinning nix-eval-jobs or do you want to wait?

@zowoq zowoq merged commit 204168e into NixOS:master Jan 20, 2023
@zowoq zowoq deleted the nix213 branch January 20, 2023 20:44
@vcunat
Copy link
Member

vcunat commented Jan 21, 2023

She update of default nix broke the tarball job and is thus blocking channels:
https://hydra.nixos.org/log/wlx6pqyzczhpzl4ips8f9gim3l3kwzqw-nixpkgs-tarball-23.05pre445417.ad161ee67ce.drv

(So far I don't get what exactly got broken there.)

@Artturin
Copy link
Member

Artturin commented Jan 21, 2023

She update of default nix broke the tarball job and is thus blocking channels: hydra.nixos.org/log/wlx6pqyzczhpzl4ips8f9gim3l3kwzqw-nixpkgs-tarball-23.05pre445417.ad161ee67ce.drv

(So far I don't get what exactly got broken there.)

maybe related to NixOS/nix#6204

@zowoq
Copy link
Contributor Author

zowoq commented Jan 21, 2023

Should we revert 956bc25 and 37a44ff for now? (no need to revert the other two)

@roberth roberth mentioned this pull request Jan 21, 2023
Closed
@roberth
Copy link
Member

roberth commented Jan 21, 2023

@zowoq sgtm

@zowoq zowoq mentioned this pull request Jan 21, 2023
Merged
13 tasks
@zowoq
Copy link
Contributor Author

zowoq commented Jan 21, 2023

#212010

@roberth Thanks for debugging and follow up on the nix side.

@Mic92
Copy link
Member

Mic92 commented Jan 22, 2023 •
edited
Loading

@zowoq for my release process of nix-eval-jobs it would be nice if I could have 2.13 in nixpkgs before it is made the default. Than I can make a release of nix-eval-jobs with the new version.

@zowoq
Copy link
Contributor Author

zowoq commented Jan 22, 2023

nix 2.13.1 is in master, we just reverted making it the default.

nix-eval-jobs is still pinned to 2.12, didn't revert as I wasn't sure if it or nix would get fixed first.

@zowoq
Copy link
Contributor Author

zowoq commented Jan 26, 2023

nix 2.13.2: #212769

@zowoq zowoq mentioned this pull request Aug 16, 2023
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@roberth roberth Awaiting requested review from roberth

@edolstra edolstra Awaiting requested review from edolstra

@Artturin Artturin Awaiting requested review from Artturin

@lovesegfault lovesegfault Awaiting requested review from lovesegfault

Assignees

No one assigned

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@zowoq @lf- @Mic92 @vcunat @Artturin @roberth