Skip to content

cargo/hooks: make vendored deps writeable if dir#211249

Closed
bennofs wants to merge 1 commit intoNixOS:masterfrom
bennofs:rust-lockfile-writeable-vendor-dir
Closed

cargo/hooks: make vendored deps writeable if dir#211249
bennofs wants to merge 1 commit intoNixOS:masterfrom
bennofs:rust-lockfile-writeable-vendor-dir

Conversation

@bennofs
Copy link
Contributor

@bennofs bennofs commented Jan 17, 2023

One case where this commonly appears is when using the cargoLock.lockfile argument to buildRustPackage. Without this fix, build scripts failed when they tried to write to the vendor dir.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@bennofs
cargo/hooks: make vendored deps writeable if dir
85e64e1 
One case where this commonly appears is when using the `cargoLock.lockfile`
argument to `buildRustPackage`.  Without this fix, build scripts failed
when they tried to write to the vendor dir.
@bennofs bennofs added the 6.topic: rust General-purpose programming language emphasizing performance, type safety, and concurrency. label Jan 17, 2023
@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Jan 17, 2023
@zowoq zowoq mentioned this pull request Mar 8, 2023
Merged
12 tasks
@figsoda
Copy link
Member

figsoda commented Mar 8, 2023

I didn't see this PR and merged #218472 which is almost identical, sorry about that @bennofs

@figsoda figsoda closed this Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

6.topic: rust General-purpose programming language emphasizing performance, type safety, and concurrency. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bennofs @figsoda