Closed
Conversation
alyssais
added
the
6.topic: portability
ofborg
bot
added
10.rebuild-darwin: 0
Member
sternenseemann
left a comment
sternenseemann
left a comment
There was a problem hiding this comment.
I guess this is o.k., but a better way to fix this, I feel like would be to make bintools wrapper link ${prefix}llvm-strings -> ${prefix}strings, given that it does link it in the GNU binutils case…
|
|
||
| outputs = [ "out" "lib" "dev" ]; | ||
|
|
||
| STRINGS = if stdenv.hostPlatform.useLLVM or false |
Member
There was a problem hiding this comment.
Hm, smells like we would need a stdenv.bintools.isLLVM or false of some kind…
Member
There was a problem hiding this comment.
I guess LLVM bintools and GCC could be mixed, but would anyone actually do that? You're probably right, though, it's something that should be done for posterity if nothing else.
alyssais
added a commit
to alyssais/nixpkgs
that referenced
this pull request
Jan 17, 2023
We were missing symlinks for some programs e.g. strings, which caused e.g. pkgsLLVM.x264 to fail to build. Here, I have filled in all the symlinks that LLVM would create if built with the LLVM_INSTALL_BINUTILS_SYMLINKS option. Where an existing symlink's target has changed, it's to avoid a double indirection e.g. strip -> llvm-strip -> llvm-objcopy has because just strip -> llvm-objcopy. There's also the related problem that we are creating a as -> llvm-as symlink, which doesn't make sense, but I'll remove that in a subsequent commit so that if it somehow breaks something it's easy to revert just that change. Fixes: NixOS#210983
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes