Skip to content

libepoxy: disable more cgl tests on x86_64-darwin#210961

Merged
vcunat merged 1 commit intoNixOS:masterfrom
wegank:libepoxy-darwin
Jan 17, 2023
Merged

libepoxy: disable more cgl tests on x86_64-darwin#210961
vcunat merged 1 commit intoNixOS:masterfrom
wegank:libepoxy-darwin

Conversation

@wegank
Copy link
Member

@wegank wegank commented Jan 15, 2023

Description of changes

Closes #210861.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Jan 15, 2023
@ofborg ofborg bot requested review from cillianderoiste and erictapen January 15, 2023 18:42
@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 501-1000 This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jan 15, 2023
@wegank wegank requested a review from vcunat January 15, 2023 18:58
@vcunat
Copy link
Member

vcunat commented Jan 15, 2023

AFAIK it was fine on aarch64-darwin, in case you wanted to be a little more "precise". But mainly I hope the failure really wasn't related to any practical issues.

@wegank wegank changed the title libepoxy: disable more cgl tests on darwin libepoxy: disable more cgl tests on x86_64-darwin Jan 15, 2023
@wegank
Copy link
Member Author

wegank commented Jan 16, 2023 •
edited
Loading

@ofborg build inkscape

@vcunat vcunat merged commit 978d992 into NixOS:master Jan 17, 2023
@vcunat
Copy link
Member

vcunat commented Jan 17, 2023

Let's not wait (for feedback) anymore.

@wegank wegank deleted the libepoxy-darwin branch January 17, 2023 07:18
vcunat added a commit that referenced this pull request Jan 18, 2023
@vcunat
Merge #210961: libepoxy: disable more cgl tests on x86_64-darwin
118e23d 
(cherry picked from commit 978d992)
https://hydra.nixos.org/build/205231923
No idea how the issue originates; it doesn't seem
like anyone's willing to investigate this deeper.
@vcunat vcunat added the 8.has: port to stable This PR already has a backport to the stable release. label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erictapen erictapen Awaiting requested review from erictapen

@cillianderoiste cillianderoiste Awaiting requested review from cillianderoiste

@vcunat vcunat Awaiting requested review from vcunat

1 more reviewer

@marsam marsam marsam approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: darwin Running or building packages on Darwin 8.has: port to stable This PR already has a backport to the stable release. 10.rebuild-darwin: 501-1000 This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

libepoxy fails to build on x86_64-darwin

3 participants

@wegank @vcunat @marsam