Skip to content

build-rust-crate: dontStrip=!release#210843

Merged
happysalada merged 1 commit intomasterfrom
unknown repository
Apr 12, 2023
Merged

build-rust-crate: dontStrip=!release#210843
happysalada merged 1 commit intomasterfrom
unknown repository

Conversation

@ghost
Copy link

@ghost ghost commented Jan 15, 2023

Description of changes

Without this PR, unlike RUST_LIB_BACKTRACE=1 cargo run you won't get line numbers in backtraces from binaries built with:

nix build -f Cargo.nix --arg release false

This PR fixes that.

Things done
  • Built on platform(s)
    • x86_64-linux
    • powerpc64le-linux
    • aarch64-linux
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Without this PR, unlike `RUST_LIB_BACKTRACE=1 cargo run` you won't
get line numbers in backtraces from binaries built with:

```
nix build -f Cargo.nix --arg release false
```

This PR fixes that.
@github-actions github-actions bot added the 6.topic: rust General-purpose programming language emphasizing performance, type safety, and concurrency. label Jan 15, 2023
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jan 15, 2023
@Artturin Artturin requested a review from happysalada April 12, 2023 19:16
@happysalada happysalada merged commit 42c8e4d into NixOS:master Apr 12, 2023
@ghost ghost deleted the pr/build-rust-crate/dontStrip branch April 13, 2023 03:54
This was referenced Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: rust General-purpose programming language emphasizing performance, type safety, and concurrency. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant