gcc: Backport fix of GCC Issue 80431 from version 12#210816
Merged
Ericson2314 merged 1 commit intoNixOS:stagingfrom Jan 17, 2023
Merged
gcc: Backport fix of GCC Issue 80431 from version 12#210816Ericson2314 merged 1 commit intoNixOS:stagingfrom
Ericson2314 merged 1 commit intoNixOS:stagingfrom
Conversation
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=80431 This bug annoys me because I hit it when working on Nix. It causes miscompilations in such a way that I am hard-pressed to think how a program could inadvertainly rely on the bug (such that it would be broken by the fix). The bug is longstanding, and the (quite small) applies without modification to many older GCCs. I have confirmed by running the test in that commit that does indeed fix the bug with the backports too.
ofborg
bot
added
the
10.rebuild-linux-stdenv
ofborg
bot
added
11.by: package-maintainer
vcunat
approved these changes
Jan 15, 2023
Member
vcunat
left a comment
vcunat
left a comment
There was a problem hiding this comment.
Sounds good.
(I didn't test that all those gcc versions are OK with this patch.)
1 task
Contributor
|
Successfully created backport PR #211255 for |
Member
Author
|
For posterity, https://gcc.gnu.org/git/?p=gcc.git;a=patch;h=de31f5445b12fd9ab9969dc536d821fe6f0edad0 is the underlying patch (can get from the PR diff too) it is quite small! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=80431
This bug annoys me because I hit it when working on Nix. It causes miscompilations in such a way that I am hard-pressed to think how a program could inadvertainly rely on the bug (such that it would be broken by the fix).
The bug is longstanding, and the (quite small) fix applies without modification to many older GCCs. I have confirmed by running the test in that commit that does indeed fix the bug with the backports too.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes