Merged
Conversation
risicle
added
1.severity: security
ofborg
bot
added
10.rebuild-darwin: 11-100
Member
|
Result of 2 packages failed to build:
10 packages built:
|
LeSuisse
approved these changes
Jan 16, 2023
Member
LeSuisse
left a comment
LeSuisse
left a comment
There was a problem hiding this comment.
nixpkgs-review happy on x86_64 (failure of credslayer is not caused by this change). The failure on Darwin x86_64 is due to #210961.
Result of nixpkgs-review pr 210742 run on x86_64-linux 1
1 package failed to build:
- credslayer
11 packages built:
- compactor
- dbmonster
- haka
- hfinger
- ostinato
- python310Packages.pyshark
- python311Packages.pyshark
- termshark
- tshark (wireshark-cli)
- wifite2
- wireshark (wireshark-qt)
1 task
Contributor
|
Successfully created backport PR #211109 for |
Member
|
Even after fixing that, x86_64-darwin is still broken: https://hydra.nixos.org/job/nixpkgs/trunk/wireshark.x86_64-darwin EDIT: but it's weird that it seems OK in the 22.11 backport, according to OfBorg. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
https://nvd.nist.gov/vuln/detail/CVE-2022-4344
https://nvd.nist.gov/vuln/detail/CVE-2022-4345
pysharktests as flaky and annoying as ever.wiresharkis currently broken on x86_64 darwin so couldn't test there.Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes