Skip to content

xorg.libpciaccess: fix build on NetBSD#210485

Merged
Ericson2314 merged 4 commits intoNixOS:stagingfrom
alyssais:libpciaccess-netbsd
Jan 13, 2023
Merged

xorg.libpciaccess: fix build on NetBSD#210485
Ericson2314 merged 4 commits intoNixOS:stagingfrom
alyssais:libpciaccess-netbsd

Conversation

@alyssais
Copy link
Member

@alyssais alyssais commented Jan 13, 2023

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@alyssais alyssais added the 6.topic: bsd Running or building packages on BSD label Jan 13, 2023
@alyssais alyssais force-pushed the libpciaccess-netbsd branch from 68a75cc to 3380791 Compare January 13, 2023 04:32
@alyssais alyssais changed the title libpciaccess: fix build on NetBSD xorg.libpciaccess: fix build on NetBSD Jan 13, 2023
@alyssais alyssais requested a review from Ericson2314 January 13, 2023 04:38
@ofborg ofborg bot added 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Jan 13, 2023
@alyssais alyssais marked this pull request as draft January 13, 2023 04:47
@alyssais alyssais changed the base branch from master to staging January 13, 2023 04:47
@github-actions github-actions bot added 6.topic: ocaml OCaml is a general-purpose, high-level, multi-paradigm programming language. 6.topic: python Python is a high-level, general-purpose programming language. 6.topic: vscode A free and versatile code editor that supports almost every major programming language. labels Jan 13, 2023
@alyssais alyssais closed this Jan 13, 2023
@alyssais alyssais reopened this Jan 13, 2023
@alyssais alyssais force-pushed the libpciaccess-netbsd branch from 3380791 to 13d8068 Compare January 13, 2023 04:49
@github-actions github-actions bot removed 6.topic: ocaml OCaml is a general-purpose, high-level, multi-paradigm programming language. 6.topic: python Python is a high-level, general-purpose programming language. 6.topic: vscode A free and versatile code editor that supports almost every major programming language. labels Jan 13, 2023
@alyssais alyssais marked this pull request as ready for review January 13, 2023 04:49
Ericson2314
Ericson2314 approved these changes Jan 13, 2023
View reviewed changes
Copy link
Member

@Ericson2314 Ericson2314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

@Ericson2314 Ericson2314 merged commit b7ceddd into NixOS:staging Jan 13, 2023
@alyssais alyssais deleted the libpciaccess-netbsd branch January 13, 2023 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Ericson2314 Ericson2314 Ericson2314 approved these changes

Assignees

No one assigned

Labels

6.topic: bsd Running or building packages on BSD 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alyssais @Ericson2314