Skip to content

proxysql: fix build after #201859#209876

Merged
dasJ merged 1 commit intoNixOS:masterfrom
helsinki-systems:fix/proxysql-py3
Jan 10, 2023
Merged

proxysql: fix build after #201859#209876
dasJ merged 1 commit intoNixOS:masterfrom
helsinki-systems:fix/proxysql-py3

Conversation

@ajs124
Copy link
Member

@ajs124 ajs124 commented Jan 9, 2023

Description of changes
  • by not pulling in python2 directly
  • by applying patches to sources we "unvendor", so e.g. libinjection builds
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ajs124 ajs124 requested a review from dasJ January 9, 2023 13:30
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Jan 9, 2023
- by not pulling in python2 directly
- by applying patches to sources we "unvendor", so e.g. libinjection builds
@ajs124 ajs124 marked this pull request as ready for review January 9, 2023 13:51
@SuperSandro2000 SuperSandro2000 changed the title proxysql: fix build after 201859 proxysql: fix build after #201859 Jan 9, 2023
@dasJ dasJ merged commit 6212a37 into NixOS:master Jan 10, 2023
@dasJ dasJ deleted the fix/proxysql-py3 branch January 10, 2023 11:12
@ajs124 ajs124 mentioned this pull request Jan 10, 2023
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants