Add macvlan support for declarative containers#20935
Conversation
|
@montag451, thanks for your PR! By analyzing the history of the files in this pull request, we identified @kampfschlaefer, @edolstra and @wlhlm to be potential reviewers. |
kampfschlaefer
left a comment
There was a problem hiding this comment.
Any chance you could add a test to prove that this works as intended and doesn't break anytime soon?
|
I use |
|
I like that! One additional suggestion: is it also possible (and) testable to ping the containers from machine1? Or is that not how macvlans works? |
|
@kampfschlaefer Yes I could ping from the host but I would have to create another macvlan (on the host) on the same network than |
|
@kampfschlaefer Finally I found a way to ping containers from host (see 6cedee9e21fe8b00cbfc910c451a1f00a34e09ca) |
|
@montag451 I think the contribution guidelines want these commits squashed, maybe the two test commits can be together? Otherwise 👍 (sadly I am not yet a member and can not merge this for you) |
6cedee9 to
b4c987d
Compare
|
@kampfschlaefer I squashed all the commits into one. Thanks again for your help 👍 |
|
Thanks! |
Motivation for this change
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)