[Do not merge*] Restore stdenv debugging at the cost of more complexity#20889
Closed
Ericson2314 wants to merge 1 commit intoNixOS:masterfrom
Closed
[Do not merge*] Restore stdenv debugging at the cost of more complexity#20889Ericson2314 wants to merge 1 commit intoNixOS:masterfrom
Ericson2314 wants to merge 1 commit intoNixOS:masterfrom
Conversation
|
@Ericson2314, thanks for your PR! By analyzing the history of the files in this pull request, we identified @nbp, @edolstra and @copumpkin to be potential reviewers. |
Ericson2314
added a commit
to Ericson2314/nixpkgs
that referenced
this pull request
Dec 4, 2016
- The darwin test can now force the use of the freshly-booted darwin stdenv - The linux test now passes enough dummy arguments This may make debugging harder, if so, check out NixOS#20889
Ericson2314
force-pushed
the
stdenv-debug
branch
from
4d6a544 to
2a56d20
Compare
Ericson2314
force-pushed
the
stdenv-debug
branch
from
2a56d20 to
e591835
Compare
Member
Author
|
I've debugged stdenv plenty of times the past year, and never once needed missed this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#15043 simplifies and cleans up the way stdenvs are bootstrapped, at the cost of removing potentially useful debugging aids. This adds back debugging aids at least as useful as the old ones, but at the cost of some complexity (though the extra stuff should all be dead code when not debugging.)
I'm, not sure whether this is a good idea or not--my hope is that by opening this anyone who's workflows are gummed up by #15043 has somewhere to turn. If that's you, feel free to merge.