darwin.builder: Instruct user not to disable firewall#208792
Closed
Gabriella439 wants to merge 1 commit intoNixOS:masterfrom
Closed
darwin.builder: Instruct user not to disable firewall#208792Gabriella439 wants to merge 1 commit intoNixOS:masterfrom
Gabriella439 wants to merge 1 commit intoNixOS:masterfrom
Conversation
github-actions
bot
added
the
8.has: documentation
ofborg
bot
added
10.rebuild-darwin: 0
It turns out that it's not necessary to disable the firewall because `qemu` by default binds to all ports (`0.0.0.0`), including `127.0.0.1`. Ideally, we would configure `qemu` to bind to `127.0.0.1` so that the user would not even be prompted to disable their firewall, but that doesn't work for unprivileged services on macOS. You heard that right. On macOS an unprivileged service can bind to `0.0.0.0:22` but not `127.0.0.1:22`. See: https://developer.apple.com/forums/thread/674179 … so right now the lesser evil is just telling users to not disable the firewall rather than requiring them to run the script with `sudo`.
Gabriella439
force-pushed
the
gabriella/builder_firewall
branch
from
11fe793 to
e330331
Compare
Member
I wasn't able to repro this, FWIW. (Is the macOS firewall opt-in?) |
Contributor
Author
|
I actually do not remember. I had it disabled on my machine but I wasn't sure if that was because I had explicitly opted out of it before |
Contributor
Author
|
It looks like the firewall is off by default, so I'll retract this pull request |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It turns out that it's not necessary to disable the firewall because
qemuby default binds to all ports (0.0.0.0), including127.0.0.1.Ideally, we would configure
qemuto bind to127.0.0.1so that the user would not even be prompted to disable their firewall, but that doesn't work for unprivileged services on macOS.You heard that right. On macOS an unprivileged service can bind to
0.0.0.0:22but not127.0.0.1:22. See:https://developer.apple.com/forums/thread/674179
… so right now the lesser evil is just telling users to not disable the firewall rather than requiring them to run the script with
sudo.Description of changes
Things done