Skip to content

darwin.builder: auto-login as the builder user#208772

Merged
Gabriella439 merged 3 commits intoNixOS:masterfrom
Gabriella439:gabriella/autologin
Jan 4, 2023
Merged

darwin.builder: auto-login as the builder user#208772
Gabriella439 merged 3 commits intoNixOS:masterfrom
Gabriella439:gabriella/autologin

Conversation

@Gabriella439
Copy link
Contributor

… as suggested by @NiklasGollenstede in:

#206951 (comment)

Description of changes
Things done

@Gabriella439 Gabriella439 requested a review from winterqt January 2, 2023 16:19
@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Jan 2, 2023
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` labels Jan 2, 2023
@Gabriella439 Gabriella439 mentioned this pull request Jan 2, 2023
13 tasks
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jan 2, 2023
Copy link
Member

@winterqt winterqt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might make sense to inline the reasoning, too (in the commit message)? IDK, LGTM otherwise.

… as suggested by @NiklasGollenstede in:

NixOS#206951 (comment)

This simplifies the user experience for logging into and
debugging the machine and also simplifies the instructions for
shutting down the machine gracefully.
@winterqt
Copy link
Member

winterqt commented Jan 3, 2023

Thanks, just want to quickly sanity check it; can do so in ~18 hours, if you don't mind waiting. Thanks again!

… as suggested by @raphaelr

Co-authored-by: Raphael Robatsch <[email protected]>
Copy link
Member

@winterqt winterqt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than that single doc nit, PTAL.

@Gabriella439 Gabriella439 merged commit 6d89aa8 into NixOS:master Jan 4, 2023
@Gabriella439 Gabriella439 deleted the gabriella/autologin branch January 4, 2023 05:13
sloane-shark pushed a commit to sloane-shark/nixpkgs that referenced this pull request Feb 17, 2023
… as suggested by @NiklasGollenstede in:

NixOS#206951 (comment)

This simplifies the user experience for logging into and
debugging the machine and also simplifies the instructions for
shutting down the machine gracefully.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: darwin Running or building packages on Darwin 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants