darwin.builder: auto-login as the builder user#208772
Merged
Gabriella439 merged 3 commits intoNixOS:masterfrom Jan 4, 2023
Merged
darwin.builder: auto-login as the builder user#208772Gabriella439 merged 3 commits intoNixOS:masterfrom
builder user#208772Gabriella439 merged 3 commits intoNixOS:masterfrom
Conversation
9a5e959 to
2cf0323
Compare
winterqt
requested changes
Jan 2, 2023
… as suggested by @NiklasGollenstede in: NixOS#206951 (comment) This simplifies the user experience for logging into and debugging the machine and also simplifies the instructions for shutting down the machine gracefully.
2cf0323 to
8ef2f07
Compare
Member
|
Thanks, just want to quickly sanity check it; can do so in ~18 hours, if you don't mind waiting. Thanks again! |
raphaelr
reviewed
Jan 3, 2023
… as suggested by @raphaelr Co-authored-by: Raphael Robatsch <[email protected]>
winterqt
reviewed
Jan 4, 2023
winterqt
approved these changes
Jan 4, 2023
Member
winterqt
left a comment
There was a problem hiding this comment.
LGTM other than that single doc nit, PTAL.
Co-authored-by: Winter <[email protected]>
sloane-shark
pushed a commit
to sloane-shark/nixpkgs
that referenced
this pull request
Feb 17, 2023
… as suggested by @NiklasGollenstede in: NixOS#206951 (comment) This simplifies the user experience for logging into and debugging the machine and also simplifies the instructions for shutting down the machine gracefully.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… as suggested by @NiklasGollenstede in:
#206951 (comment)
Description of changes
Things done
Built on platform(s)
Tested, as applicable:
Fits CONTRIBUTING.md.