Skip to content

Windows/OS X cross builds, a few more fixes#2087

Merged
aszlig merged 5 commits intoNixOS:cross-win-osxfrom
xtruder:crossdev
Apr 19, 2014
Merged

Windows/OS X cross builds, a few more fixes#2087
aszlig merged 5 commits intoNixOS:cross-win-osxfrom
xtruder:crossdev

Conversation

@offlinehacker
Copy link
Contributor

Just a few more fixes to consider, while doing cross builds: #1928

PS: Some changes might not seem to be directly related to cross builds, but happened to me while i was doing cross builds, so i put them here :)

vcunat and others added 5 commits March 30, 2014 20:40
Unfortunately github's *.patch URIs contain version of git generating them,
which changes from time to time. It seems that *.diff doesn't suffer from that.

Conflicts:
	pkgs/development/libraries/libarchive/default.nix
@shlevy
Copy link
Member

shlevy commented Apr 5, 2014

IMO the default of not having static is a good one, as pretty much all potential issues with dynamic linking are fixed by nix in general. But if you need static libraries for a particular use case I see no problem having an option for it.

@offlinehacker
Copy link
Contributor Author

@aszlig it's ready for merge, it goes into your crossdev branch
On Apr 5, 2014 8:34 PM, "Shea Levy" [email protected] wrote:

IMO the default of not having static is a good one, as pretty much all
potential issues with dynamic linking are fixed by nix in general. But if
you need static libraries for a particular use case I see no problem having
an option for it.

Reply to this email directly or view it on GitHubhttps://github.com//pull/2087#issuecomment-39646847
.

@shlevy
Copy link
Member

shlevy commented Apr 5, 2014

Wow a PR to non-master, we're almost using git properly! ;)

@aszlig aszlig self-assigned this Apr 6, 2014
@aszlig aszlig merged commit 7762034 into NixOS:cross-win-osx Apr 19, 2014
aszlig added a commit that referenced this pull request Apr 19, 2014
Thanks to @offlinehacker for the fixes.

* 'crossdev' of github.com:offlinehacker/nixpkgs:
  gifsicle: add optional static builds, make gifview optional
  libjpeg_original: add optional static builds
  optipng: use system libpng & zlib, fix cross builds and add ...
  xcode: fix hash
  libarchive: *permanently* fix patch source and hash
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0.kind: enhancement Add something new or improve an existing system.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants