nixos/version: Only warn about unset stateVersion if used (lite)#207958
Merged
roberth merged 4 commits intoNixOS:masterfrom Dec 28, 2022
Merged
Conversation
github-actions
bot
added
6.topic: nixos
ofborg
bot
added
10.rebuild-darwin: 1-10
13 tasks
Member
|
What about dropping the default altogether? |
Member
Author
The default default or the macOS one? The macOS linux builder one seems valuable enough because it adds a bit of explanation. I'm ok with removing the |
Contributor
Gabriella439
left a comment
Gabriella439
left a comment
There was a problem hiding this comment.
Looks great! Just a few small suggestions
If a configuration does not use services that depend on the stateVersion, it does not need to be set. This provides an incentive for services not to rely on stateVersion, and not to burden users with this.
ofborg
bot
added
the
2.status: merge conflict
The `system` argument is usually implied, and not hard to figure out. Co-authored-by: Gabriella Gonzalez <[email protected]>
I was considering the broader context of stateVersion, but the macos builder does not enable documentation, making this paragraph a distraction.
roberth
force-pushed
the
nixos-only-warn-stateVersion-when-used-lite
branch
from
e213eae to
91050a9
Compare
ofborg
bot
removed
the
2.status: merge conflict
13 tasks
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
If a configuration does not use services that depend on the
stateVersion, it does not need to be set.This provides an incentive for services not to rely on
stateVersion, and not to burden users with this.Currently, it is still required by some modules, so to make a valid
stateVersion-less configuration you'll have to usedisabledModules.This change forms the foundation of #207313, which has breaking changes, while this pr does not.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes