Skip to content

lldb_14: fix broken python3 site-packages and lua5_3#207863

Merged
7c6f434c merged 8 commits intoNixOS:masterfrom
patryk4815:fix-lldb
Feb 4, 2023
Merged

lldb_14: fix broken python3 site-packages and lua5_3#207863
7c6f434c merged 8 commits intoNixOS:masterfrom
patryk4815:fix-lldb

Conversation

@patryk4815
Copy link
Contributor

@patryk4815 patryk4815 commented Dec 26, 2022

Description of changes

This should fix issue #166604
And I fixed lua install dir also :)

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@patryk4815
Copy link
Contributor Author

patryk4815 commented Dec 26, 2022

@ofborg build lldb_8 lldb_9 lldb_10 lldb_11 lldb_12 lldb_13 lldb_14

@ofborg ofborg bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Dec 26, 2022
@LunNova
Copy link
Member

LunNova commented Dec 26, 2022

Would it be worth adding the lua files to installCheckPhase too?

@patryk4815
Copy link
Contributor Author

patryk4815 commented Dec 26, 2022

@LunNova Ok I will add :)

@LunNova
Copy link
Member

LunNova commented Dec 26, 2022

Result of nixpkgs-review pr 207863 run on x86_64-linux 1

1 package marked as broken and skipped:
  • jucipp
8 packages built:
  • lldb (lldb_14 ,llvmPackages_14.lldb ,llvmPackages_latest.lldb)
  • lldb_10 (llvmPackages_10.lldb)
  • lldb_11 (llvmPackages.lldb ,llvmPackages_11.lldb)
  • lldb_12 (llvmPackages_12.lldb)
  • lldb_13 (llvmPackages_13.lldb)
  • lldb_8 (llvmPackages_8.lldb ,vscode-extensions.llvm-org.lldb-vscode)
  • lldb_9 (llvmPackages_9.lldb)
  • vscode-extensions.vadimcn.vscode-lldb

@patryk4815 patryk4815 force-pushed the fix-lldb branch 2 times, most recently from cc2d2e4 to b39aa90 Compare December 26, 2022 20:48
@patryk4815
Copy link
Contributor Author

patryk4815 commented Dec 26, 2022

@LunNova Added lua check :)

@patryk4815
Copy link
Contributor Author

patryk4815 commented Dec 26, 2022

@ofborg build lldb_14

@LunNova LunNova mentioned this pull request Dec 27, 2022
Merged
92 tasks
@7c6f434c 7c6f434c merged commit 01b91d1 into NixOS:master Feb 4, 2023
@rrbutani rrbutani mentioned this pull request Feb 14, 2023
Closed
48 tasks
@rrbutani rrbutani added the 6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related label May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LunNova LunNova LunNova approved these changes

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

@dtzWill dtzWill Awaiting requested review from dtzWill

@primeos primeos Awaiting requested review from primeos

@lovek323 lovek323 Awaiting requested review from lovek323

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

@thefloweringash thefloweringash Awaiting requested review from thefloweringash

Assignees

No one assigned

Labels

6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@patryk4815 @LunNova @7c6f434c @rrbutani