Merged
Conversation
Contributor
|
Note the other warning though: always use the same flags for this and the library linking against. |
Contributor
We're already building it with C++17 as the default version used by GCC on |
70d6df5 to
a20d967
Compare
Member
Author
|
@tobim, agreed |
Contributor
|
@ofborg build rapidjson |
Member
Author
|
@GrahamcOfBorg eval |
Member
Author
|
Result of 520 packages marked as broken and skipped:
641 packages failed to build:
534 packages built:
|
This was referenced Feb 11, 2023
veprbl
added a commit
to veprbl/nixpkgs
that referenced
this pull request
Feb 13, 2023
Was fixed by 2f8e6f3 ('gtest: ensure C++17 support (NixOS#207338)')
veprbl
added a commit
that referenced
this pull request
Feb 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Fix to address an issue seen in #198805:
Turns out
GTEST_INTERNAL_HAS_STRING_VIEWneeds to be detected when gtest libraries are compiled, and then it should work. This enables -std=c++17 as it's the way intended by upstream google/googletest#3081 (comment)Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes