nixos/version: Only warn about unset stateVersion if used#207313
Draft
roberth wants to merge 4 commits intoNixOS:masterfrom
Draft
nixos/version: Only warn about unset stateVersion if used#207313roberth wants to merge 4 commits intoNixOS:masterfrom
roberth wants to merge 4 commits intoNixOS:masterfrom
Conversation
a282feb to
0505f74
Compare
If a configuration does not use services that depend on the stateVersion, it does not need to be set. This provides an incentive for services not to rely on stateVersion, and not to burden users with this.
This change has the effect of allowing an empty configuration to be valid without stateVersion.
This change has the effect of allowing an empty configuration to be valid without stateVersion.
0505f74 to
2149d0a
Compare
13 tasks
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Only warn about unset
stateVersionif used.If a configuration does not use services that depend on the stateVersion, it does not need to be set.
This provides an incentive for services not to rely on stateVersion, and not to burden users with this.
(not judging service authors who need it)
I hope this
apply-based solution is the missing ingredient that made the apparent previous attempt fail. It built the manual locally. Eagerly awaiting CI results... EDIT: nixos-unstable is broken.Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes