Skip to content

gtk: backport fix for correctly render cursors#207113

Closed
pasqui23 wants to merge 1 commit intoNixOS:stagingfrom
pasqui23:gtk-mouse
Closed

gtk: backport fix for correctly render cursors#207113
pasqui23 wants to merge 1 commit intoNixOS:stagingfrom
pasqui23:gtk-mouse

Conversation

@pasqui23
Copy link
Contributor

@pasqui23 pasqui23 commented Dec 21, 2022 •
edited by bobby285271
Loading

Description of changes

A redo of #207100
GTK applications without this patch will not render mouse cursors correctly, making them almost unusable on anywhere other than GNOME desktop with stock cursors or on X11.

I've tested this by buildiing and running both firefox and thunderbird

Closes #207339

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 501-1000 This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches. labels Dec 21, 2022
jtojnar
jtojnar reviewed Dec 21, 2022
View reviewed changes
@ofborg ofborg bot requested a review from jtojnar December 21, 2022 23:38
@bobby285271
Copy link
Member

bobby285271 commented Dec 23, 2022 •
edited
Loading

3.24.36 is tagged, hopefully it can also cover the issue (still didn't test yet) 🙇 (the commit msg should be prefixed with gtk3: so ofborg can build this automatically)

@jtojnar
Copy link
Member

jtojnar commented Dec 23, 2022 •
edited
Loading

Looks like the patch was reverted so I am 👎 on cherry picking it: https://gitlab.gnome.org/GNOME/gtk/-/merge_requests/5329 (more context https://gitlab.gnome.org/GNOME/gtk/-/issues/5388)

@pasqui23
Copy link
Contributor Author

pasqui23 commented Dec 23, 2022

It still remains that without the patch Firefox becomes unusable and the workaround suggested on other distros (ln -s ~/.icons /usr/share/icons) is not applicable on NixOS.

@jtojnar
Copy link
Member

jtojnar commented Dec 23, 2022

You should still be able to install the icon theme to a path under XDG_DATA_DIRS (e.g. using environment.systemPackages, home-manager or nix-env).

@baloo
Copy link
Member

baloo commented Jan 4, 2023

3.24.36 got tagged and includes https://gitlab.gnome.org/GNOME/gtk/-/commit/91c37c8692753febe0f89133f26a63af80f03ca4

@baloo baloo mentioned this pull request Jan 4, 2023
Merged
13 tasks
@pasqui23 pasqui23 closed this Jan 4, 2023
@pasqui23 pasqui23 deleted the gtk-mouse branch May 6, 2023 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

@dasj19 dasj19 Awaiting requested review from dasj19

@hedning hedning Awaiting requested review from hedning

@amaxine amaxine Awaiting requested review from amaxine

@bobby285271 bobby285271 Awaiting requested review from bobby285271

@jtojnar jtojnar Awaiting requested review from jtojnar

Assignees

No one assigned

Labels

10.rebuild-darwin: 501-1000 This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pasqui23 @bobby285271 @jtojnar @baloo