Skip to content

awscli2: make version widening more robust#206460

Merged
vcunat merged 1 commit intoNixOS:staging-nextfrom
SuperSandro2000:staging-next-awscli2
Dec 17, 2022
Merged

awscli2: make version widening more robust#206460
vcunat merged 1 commit intoNixOS:staging-nextfrom
SuperSandro2000:staging-next-awscli2

Conversation

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Dec 16, 2022

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@SuperSandro2000 SuperSandro2000 mentioned this pull request Dec 16, 2022
Merged
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Dec 16, 2022
anthonyroussel
anthonyroussel approved these changes Dec 16, 2022
View reviewed changes
Copy link
Member

@anthonyroussel anthonyroussel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nixpkgs-review pr 206460 run on x86_64-linux 1

2 packages built:
  • awscli2
  • liquidsoap

dotlambda
dotlambda reviewed Dec 17, 2022
View reviewed changes
Copy link
Member

@dotlambda dotlambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not use pythonRelaxDepsHook?

@vcunat vcunat merged commit ae1bac8 into NixOS:staging-next Dec 17, 2022
@vcunat
Copy link
Member

vcunat commented Dec 17, 2022

I merged a bit early. Better have it working than not. Certainly feel free to improve further.

@SuperSandro2000 SuperSandro2000 deleted the staging-next-awscli2 branch December 24, 2022 01:14
@SuperSandro2000
Copy link
Member Author

SuperSandro2000 commented Dec 24, 2022

Why not use pythonRelaxDepsHook?

that only works with requirements.txt

@dotlambda
Copy link
Member

dotlambda commented Dec 24, 2022

Why not use pythonRelaxDepsHook?

that only works with requirements.txt

No, also with pyproject.toml and some others.

@SuperSandro2000
Copy link
Member Author

SuperSandro2000 commented Jan 6, 2023

thats only mentioned in the last sentence of https://github.com/NixOS/nixpkgs/blob/master/doc/languages-frameworks/python.section.md#using-pythonrelaxdepshook-using-pythonrelaxdepshook and up to that point examples are only given for requirements.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dotlambda dotlambda dotlambda left review comments

@anthonyroussel anthonyroussel anthonyroussel approved these changes

@bhipple bhipple Awaiting requested review from bhipple

@bryanasdev000 bryanasdev000 Awaiting requested review from bryanasdev000

@davegallant davegallant Awaiting requested review from davegallant

@devusb devusb Awaiting requested review from devusb

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@SuperSandro2000 @vcunat @dotlambda @anthonyroussel