Skip to content

llvm: disable libpfm on all non-Linux platforms#205355

Merged
Artturin merged 1 commit intoNixOS:masterfrom
alyssais:llvm-libpfm
Dec 21, 2022
Merged

llvm: disable libpfm on all non-Linux platforms#205355
Artturin merged 1 commit intoNixOS:masterfrom
alyssais:llvm-libpfm

Conversation

@alyssais
Copy link
Member

@alyssais alyssais commented Dec 9, 2022

Description of changes

libpfm is Linux-specific, it should be disabled on e.g. FreeBSD as well as Darwin.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@alyssais
llvm: disable libpfm on all non-Linux platforms
126229f 
libpfm is Linux-specific, it should be disabled on e.g. FreeBSD as
well as Darwin.
@alyssais alyssais added the 6.topic: portability General portability concerns, not specific to cross-compilation or a specific platform label Dec 9, 2022
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Dec 9, 2022
@Artturin Artturin merged commit 3061b3b into NixOS:master Dec 21, 2022
@rrbutani rrbutani mentioned this pull request Jan 8, 2023
Merged
92 tasks
@rrbutani rrbutani mentioned this pull request Mar 26, 2023
Closed
48 tasks
rrbutani added a commit to rrbutani/nixpkgs that referenced this pull request Apr 3, 2023
@rrbutani
llvmPackages_git: apply NixOS#205355 (disable libpfm on non-Linux)
75fed51 
this was applied to `llvmPackages_15` in 81ef82a
(though I appear to have forgotten to mention it in the commit message...)
rrbutani added a commit to rrbutani/nixpkgs that referenced this pull request Apr 5, 2023
@rrbutani
llvmPackages_git: apply NixOS#205355 (disable libpfm on non-Linux)
633cd0e 
this was applied to `llvmPackages_15` in 81ef82a
(though I appear to have forgotten to mention it in the commit message...)
RaitoBezarius added a commit that referenced this pull request Apr 19, 2023
@RaitoBezarius
Merge pull request #222902 from rrbutani/fix/llvm-git-disable-libpfm
01a6895 
llvmPackages_git: apply #205355 (disable libpfm on non-Linux)
@alyssais alyssais deleted the llvm-libpfm branch September 22, 2023 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dtzWill dtzWill Awaiting requested review from dtzWill

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

1 more reviewer

@trofi trofi trofi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: portability General portability concerns, not specific to cross-compilation or a specific platform 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alyssais @trofi @Artturin