cc-wrapper: -march= is not allowed on powerpc#205242
Merged
sternenseemann merged 1 commit intomasterfrom Jan 10, 2023
unknown repository
Merged
cc-wrapper: -march= is not allowed on powerpc#205242sternenseemann merged 1 commit intomasterfrom unknown repository
sternenseemann merged 1 commit intomasterfrom
unknown repository
Conversation
Gcc does not allow `-march=` on PowerPC: https://gcc.gnu.org/onlinedocs/gcc-12.2.0/gcc/RS_002f6000-and-PowerPC-Options.html#RS_002f6000-and-PowerPC-Options Instead, `-mcpu=` should be used to set the minimum instruction set and `-mtune=` is used to optimize instruction scheduling for a specific processor. Both flags take the same set of valid values, which includes `native`. This commit causes `isGccArchSupported` to return `false` for PowerPC targets so we never pass an `-march=` flag, since that will always be rejected by gcc.
ghost
requested a review
from 
ghost
mentioned this pull request
5 tasks
Atemu
approved these changes
Dec 9, 2022
Member
Atemu
left a comment
Atemu
left a comment
There was a problem hiding this comment.
From what I could find, the premise is true and the diff lgtm.
SuperSandro2000
approved these changes
Dec 9, 2022
Member
|
@ofborg eval |
ofborg
bot
added
10.rebuild-darwin: 0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Gcc does not allow
-march=on PowerPC:https://gcc.gnu.org/onlinedocs/gcc-12.2.0/gcc/RS_002f6000-and-PowerPC-Options.html#RS_002f6000-and-PowerPC-Options
Instead,
-mcpu=should be used to set the minimum instruction set and-mtune=is used to optimize instruction scheduling for a specific processor. Both flags take the same set of valid values, which includesnative.This commit causes
isGccArchSupportedto returnfalsefor PowerPC targets so we never pass an-march=flag, since that will always be rejected by gcc.Things done