cc-wrapper: add support for ARM feature flags#205086
Closed
Conversation
GCC and Clang both accept a suffix consisting of zero or more "feature flags" to the values of `-march` and `-mcpu`: https://gcc.gnu.org/onlinedocs/gcc-12.2.0/gcc/AArch64-Options.html#g_t-march-and--mcpu-Feature-Modifiers Let's provide a way for users to enable these feature modifiers in `{local,cross}System.gcc`.
ofborg
bot
added
10.rebuild-darwin: 0
ghost
mentioned this pull request
13 tasks
ghost
marked this pull request as ready for review
ghost
marked this pull request as draft
ghost
marked this pull request as ready for review
ghost
closed this
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
On Aarch64, GCC and Clang both accept a suffix consisting of zero or more "feature flags" to the values of
-marchand-mcpu:https://gcc.gnu.org/onlinedocs/gcc-12.2.0/gcc/AArch64-Options.html#g_t-march-and--mcpu-Feature-Modifiers
Let's provide a way for users to enable these feature modifiers in
{local,cross}System.gcc.CC: @alyssais @Ericson2314
Things done
gcc.featureModifiers=["crc" "crypto"])