Merged
Conversation
github-actions
bot
added
6.topic: python
roberth
added
the
6.topic: closure size
13 tasks
ofborg
bot
added
10.rebuild-darwin: 11-100
The code and typical use case suggest that ghostscript is not used graphically. Removing this dependency reduces the build closure of many tools that use texlive for documentation. If this needs to be reverted, please state the graphical use case in a comment, so we don't make this mistake again.
matplotlib does not seem to use ghostscript in its graphical / interactive capacity, based on quick scan through the docs and github code search. If this needs to be reverted, please state the graphical use case in a comment, so we don't make this mistake again.
roberth
force-pushed
the
init-ghostscript_headless
branch
from
a9d5dca to
64c6e21
Compare
veprbl
approved these changes
Dec 7, 2022
Member
veprbl
left a comment
veprbl
left a comment
There was a problem hiding this comment.
Both texlive and matplotlib changes make sense to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
This reduces the build closure of many derivations that don't already need user interface or printing libraries.
I'm not 100% confident that a graphical ghostscript isn't necessary, but it is highly likely, and this seems to be the only way to find out. I've checked the project documentation and nixpkgs git blame for clues.
I'm not doing this through the NixOS no-x-libs overlay, because this should improve many packages that have no business having graphical libraries in their build closure, saving many rebuilds, regardless of whether the user wants to optimize for a non-graphical system configuration.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes