Skip to content

openldap: try to fix test error#204554

Merged
mweinelt merged 1 commit intoNixOS:staging-nextfrom
tjni:openldap
Dec 5, 2022
Merged

openldap: try to fix test error#204554
mweinelt merged 1 commit intoNixOS:staging-nextfrom
tjni:openldap

Conversation

@tjni
Copy link
Contributor

@tjni tjni commented Dec 4, 2022

Description of changes

I saw this fix the failing test in a VM, but I also had some other changes locally for debugging, so I want to see what happens on CI.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@tjni
Copy link
Contributor Author

tjni commented Dec 4, 2022

@ofborg build openldap

@ofborg ofborg bot requested review from ajs124, dasJ and mweinelt December 4, 2022 23:49
@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 501-1000 This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches. labels Dec 4, 2022
@tjni tjni mentioned this pull request Dec 5, 2022
Merged
13 tasks
ajs124
ajs124 approved these changes Dec 5, 2022
View reviewed changes
Copy link
Member

@ajs124 ajs124 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didn't test, but looks reasonable enough to me

@mweinelt
Copy link
Member

mweinelt commented Dec 5, 2022

@ofborg test openldap

@mweinelt mweinelt merged commit abcae20 into NixOS:staging-next Dec 5, 2022
@tjni tjni deleted the openldap branch December 5, 2022 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ajs124 ajs124 ajs124 approved these changes

@dasJ dasJ Awaiting requested review from dasJ

@mweinelt mweinelt Awaiting requested review from mweinelt

Assignees

No one assigned

Labels

10.rebuild-darwin: 501-1000 This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tjni @mweinelt @ajs124